Skip to content

aigcpanel 0.12.0 (new cask) #217197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

modstart
Copy link
Contributor

@modstart modstart commented Jun 21, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@modstart modstart marked this pull request as draft June 21, 2025 09:01
@modstart modstart closed this Jun 21, 2025
@modstart modstart reopened this Jun 21, 2025
@modstart modstart closed this Jun 21, 2025
@modstart modstart reopened this Jun 21, 2025
@modstart modstart closed this Jun 21, 2025
@modstart modstart reopened this Jun 21, 2025
@modstart modstart marked this pull request as ready for review June 21, 2025 09:59
@modstart modstart marked this pull request as draft June 21, 2025 10:00
@modstart modstart closed this Jun 21, 2025
@modstart modstart reopened this Jun 21, 2025
@modstart modstart marked this pull request as ready for review June 21, 2025 10:09
@khipp khipp changed the title Create aigcpanel.rb aigcpanel 0.12.0 (new cask) Jun 21, 2025
@ivaquero
Copy link
Contributor

ivaquero commented Jun 21, 2025

Hi, this manifest is for AigcpanelPro, right? Aigcpanel means the community edition according to the official website.

We maintain unofficially both the two versions's manifests at https://github.com/Brewforge/homebrew-chinese/blob/main/Casks/a/aigcpanel.rb and
https://github.com/Brewforge/homebrew-chinese/blob/main/Casks/a/aigcpanel-pro.rb

You may update the zap sections based on the above ones.

@modstart
Copy link
Contributor Author

Hi, this manifest is for AigcpanelPro, right? Aigcpanel means the community edition according to the official website.

We maintain unofficially both the two versions's manifests at https://github.com/Brewforge/homebrew-chinese/blob/main/Casks/a/aigcpanel.rb and https://github.com/Brewforge/homebrew-chinese/blob/main/Casks/a/aigcpanel-pro.rb

You may update the zap sections based on the above ones.

community edition and the pro version all supported

@ivaquero
Copy link
Contributor

Once this PR get merged, I will delete the two manifests above.

@modstart
Copy link
Contributor Author

Once this PR get merged, I will delete the two manifests above.

OK

@modstart modstart requested a review from khipp June 24, 2025 00:58
Copy link
Member

@bevanjkay bevanjkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two casks should have a conflicts_with stanza because they can't both be installed at the same time.

@modstart
Copy link
Contributor Author

These two casks should have a conflicts_with stanza because they can't both be installed at the same time.

I added the conflicts_with stanza, but the CI test failed.
Would it be better to submit a PR for only one cask at a time, or should I add the conflicts_with stanza in a separate PR afterward?

/opt/homebrew/Library/Homebrew/cask/cask_loader.rb:565:in 'Cask::CaskLoader::NullLoader#load': Cask 'aigcpanel' is unavailable: No Cask with this name exists. (Cask::CaskUnavailableError)
from /opt/homebrew/Library/Homebrew/cask/cask_loader.rb:574:in 'Cask::CaskLoader.load'
from -:18:in 'block in

'
from -:18:in 'Array#select'
from -:18:in ''

@bevanjkay
Copy link
Member

Yes, sorry about that. It looks like we'll have to add it in a follow up PR, once the API has propagated.

@modstart
Copy link
Contributor Author

Yes, sorry about that. It looks like we'll have to add it in a follow up PR, once the API has propagated.

To avoid this issue, I'll start by submitting one file per PR.

@modstart modstart requested a review from bevanjkay June 24, 2025 01:35
@bevanjkay
Copy link
Member

Thank you @modstart
Can you please try to squash the commits?

@modstart
Copy link
Contributor Author

Thank you @modstart Can you please try to squash the commits?

Sorry about that. I’ve squashed the commits as requested.

@bevanjkay bevanjkay requested a review from samford June 24, 2025 02:09
@modstart modstart force-pushed the modstart-lib-updater branch 2 times, most recently from 647504f to 8f85c10 Compare June 24, 2025 03:17
@modstart modstart force-pushed the modstart-lib-updater branch from 8f85c10 to 249c90d Compare June 24, 2025 03:20
@bevanjkay bevanjkay added this pull request to the merge queue Jun 24, 2025
Merged via the queue into Homebrew:master with commit ea2e884 Jun 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants