-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Enable Bash completions for formulae using :click
#229665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
f19a771
to
a077bfa
Compare
@StenAL restarted the build in a way that should decrease chances of timeout. If it still times out (or if any formulae fail): please extract failing formulae/some formulae into separate PRs. |
Thanks for your contributions @StenAL! I've approved most of the PR's. Users will need to |
Description
Click can generate completions for Bash versions newer than 4.4. Bash was previously excluded from the completions list because even generating the completions needed a new version of Bash. This is no longer the case meaning the completions can always be generated, even if the system is using an old version of Bash (e.g. macOS's built-in Bash running v3.2.57).
Changes generated by running:
And manually fixing up any formulae that used multi-line
generate_completions_from_executable
calls.Fixes Homebrew/brew#20188
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?