offboard from eslint in superlinter #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian DeHamer <bdehamer@github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR disables ESLint within super-linter due to compatibility issues with ESLint v9 and adds an explicit ESLint step.
- Disables ESLint in super-linter by setting VALIDATE_TYPESCRIPT_ES to false.
- Upgrades the super-linter version reference in the workflow.
- Introduces a new step to run ESLint via npm.
ejahnGithub
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop running eslint as part of the super-linter action. We've been pinned to an old version of super-linter cause the newer versions are not compatible with our updated eslint config. Until super-linter has support for eslint v9 we should leave this disabled.
Adds an explicit call to eslint to make-up for disabling it in super-linter.