Update configure-apt-mock.sh to enable parallelism #11467
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav3yblaz3
approved these changes
Jan 26, 2025
|
I have more extensive changes coming to actually enable parallelism. This PR is now weeks old, which doesn't bode well for the rest of my changes. Is there any interest from the actual team? |
|
Thank you @xximwon , but I need someone "with write access" to approve this PR. |
|
ping @subir0071 , looks like CI passed, mind approving/merging it? |
|
Hi @fahhem , Kindly rebase your Pr, thanks |
This adds a few errors that happen when another update/install process is running in parallel. `apt-get update` doesn't handle race conditions well, and `apt-get install` has one as well. This is pre-cursor to another change that enables parallelism in the packer templates to run the `install-*.sh` scripts parallel, as I mentioned in https://github.com/actions/runner-images/discussions/2320
|
@vidyasagarnimmagaddi rebased, but nothing changed in the rebase so the diffs are the same. |
|
@vidyasagarnimmagaddi thank you, looks like CI still passes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a few errors that happen when another update/install process is running in parallel.
apt-get updatedoesn't handle race conditions well, andapt-get installhas one as well.This is pre-cursor to another change that enables parallelism in the packer templates to run the
install-*.shscripts parallel, as I mentioned in https://github.com/actions/runner-images/discussions/2320On its own, this change does nothing, except maybe slightly increase reliability of image building.
Check list