chore: deployment page title #1980
Open
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The preview deployment failed. 🔴 Last updated at: 2025-06-03 10:23:49 CET |
|
The preview deployment failed. 🔴 Last updated at: 2025-06-03 10:23:42 CET |
ItzNotABug
reviewed
Jun 3, 2025
| href={`${base}/project-${page.params.region}-${projectId}/functions/function-${functionId}`}> | ||
| Deployment | ||
| href={`${base}/project-${page.params.region}-${page.params.project}/functions/function-${page.params.function}`}> | ||
| {$func.name}'s deployment |
There was a problem hiding this comment.
The CoverTitle component truncates long text
There was a problem hiding this comment.
but that would also truncate the text deployment as well right? 👀
Shouldn't the deployment page's title should mention deployment?
LoremIpsumLongFunctio's deployment > LoremIpsum...
isn't that same as function's title then?
There was a problem hiding this comment.
Yeah, that's the downside of adding the function/site name... you can bring it up with design on discord
| import { deployment } from './store'; | ||
| </script> | ||
|
|
||
| <Cover> | ||
| <svelte:fragment slot="header"> | ||
| <CoverTitle | ||
| href={`${base}/project-${page.params.region}-${page.params.project}/sites/site-${page.params.site}/deployments`}> | ||
| Deployment | ||
| {$site.name}'s deployment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.