SliderPrecision component #20032
Merged
SliderPrecision component #20032
+75
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Usability
alice-i-cecile
added
X-Uncontroversial
alice-i-cecile
approved these changes
Jul 8, 2025
alice-i-cecile
added
S-Needs-Review
ickshonpe
suggested changes
Jul 9, 2025
| @@ -324,13 +359,16 @@ pub(crate) fn slider_on_drag( | |||
| } else { | |||
| range.start() + span * 0.5 | |||
| }; | |||
| let rounded_value = precision | |||
| .map(|prec| prec.round(new_value)) | |||
There was a problem hiding this comment.
Need to clamp here, otherwise it can round the value to outside of the slider range
Suggested change
| .map(|prec| prec.round(new_value)) | |
| .map(|prec| range.clamp(prec.round(new_value))) |
There was a problem hiding this comment.
I'll do this slightly differently, because I don't want to clamp twice.
ickshonpe
suggested changes
Jul 9, 2025
| @@ -257,7 +288,9 @@ pub(crate) fn slider_on_pointer_down( | |||
| value.0 + step.0 | |||
| } | |||
| } | |||
| TrackClick::Snap => click_val, | |||
| TrackClick::Snap => precision | |||
| .map(|prec| prec.round(click_val)) | |||
There was a problem hiding this comment.
Suggested change
| .map(|prec| prec.round(click_val)) | |
| .map(|prec| range.clamp(prec.round(click_val))) |
There was a problem hiding this comment.
This is already clamped, see previous lines.
ickshonpe
approved these changes
Jul 9, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
|
@viridia ping me when merge conflicts are resolved please :) |
|
Rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
SliderPrecisioncomponent that lets you control the rounding when dragging a slider.Part of #19236