-
-
Notifications
You must be signed in to change notification settings - Fork 4k
StandardMaterial docs: Make clear that lighting won't look correct if is_srgb
is true
#20037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
is_srgb
is false
is_srgb
is true
@DGriffin91 does this look right to you? |
Yes, this looks correct. A few of the examples do exactly this, and the GLTF loader deals with it here: bevy/crates/bevy_gltf/src/loader/mod.rs Line 1062 in fb2bbb0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@772, please ping me once CI is passing and I'll get this merged for you :) It looks like you're going to need to add a bit of boilerplate above your code snippet. Feel free to just mock it if needed and then use #
to hide the mocked lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for working on this!
@alice-i-cecile |
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
Alright, let's try that :) |
Objective
Solution
Testing
cargo doc --no-deps --open
.