Allow UnevenSampleCurve to infer interpolation arguments from samples #20046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
bevy_math::curve::UnevenSampleCurve
was lacking trait bounds on itsnew
method which caused a need to manually specify interpolation function argument types, even though the types are already known from the timed_samples argument.Solution
This adds the
Fn
trait bound to the new method, matching the behaviour ofSampleCurve
.Testing
I added a test which doesn't actually test for any runtime behaviour, instead writing code that would error before this PR.
Showcase
It's now possible to create a
UnevenSampleCurve
without specifying the interpolation closure argument types.Sidenote
Seeing
x
andy
in lerp feels wrong, I've always useda
andb
to avoid confusion with coordinates.