Skip to content

bug when directory is "." catches more impacted projects than it should #1988

Open
@motatoes

Description

@motatoes

I just noticed this when doing some testing in a digger.yml like this:

projects: 
   - name: first
     dir: .
  - name: second
     dir: .
  - name: dev
     dir: dev/

lets say a file called called "dev/main.tf" was changed, I saw that digger triggers plans for all projects (first, second and dev).

Expected behaviour: only "dev" is supposed to be impacted. Found that the issue is here: https://github.com/diggerhq/digger/blob/develop/libs/digger_config/digger_config.go#L870

			if !project.Terragrunt {
				includePatterns = append(includePatterns, filepath.Join(project.Dir, "**", "*"))
			} else {
				includePatterns = append(includePatterns, filepath.Join(project.Dir, "*"))
			}

In particular not sure why we add the double star glob pattern when the project is not terragrunt. git blame isn't helping me here because the commit was swallowed pre large refactor. But I believe we should just keep it to a single pattern to avoid this bug

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions