Fix flaky ReadBufferLimitTest/SomeLimit test #40206
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ted Poole <tpoole@redhat.com>
tedjpoole
force-pushed
the
flakey-read-buffer-limit-test
branch
from
721a8b7 to
2393b30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky ReadBufferLimitTest/SomeLimit test
The
ReadBufferLimitTest/SomeLimittest intermittently fails on some dev machines due to the unpredictable behaviour ofreadv()calls which occasionally don't fill the buffers provided to it i.e. not enough data available to read from the socket. When this happens, the test fails because there is an incorrect (off by 1) assertion on the maximum chunk size that the server side ReadFilter should see.This PR adds a new
short_readvparameter to the test. If this parameter is zero, the test behaves as before, but it it is non-zero then the test mocks the necessary system calls in order to deterministically emulate the scenario wherereadv()doesn't manage to fill the buffers provided to it.Fixes #40147