Remove s3 requirement #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+14
to
+15
| os: ['ubuntu-20.04'] | ||
| ruby-version: ['3.0', '3.1'] |
There was a problem hiding this comment.
I've added a matrix for testing. Let me know which values you want to test with.
| @@ -40,6 +40,7 @@ Gem::Specification.new do |spec| | |||
| # own Gemfile when using this. | |||
| spec.add_development_dependency 'aws-sdk-ecr' | |||
| spec.add_development_dependency 'aws-sdk-s3' | |||
| spec.add_development_dependency 'webrick' | |||
There was a problem hiding this comment.
Why do we need this gem?
Comment on lines
+7
to
+19
| # require_relative 'exercism_config/environment' | ||
| # require_relative 'exercism_config/determine_environment' | ||
| # require_relative 'exercism_config/generate_aws_settings' | ||
| # require_relative 'exercism_config/setup_dynamodb_client' | ||
| # require_relative 'exercism_config/setup_ecr_client' | ||
| # require_relative 'exercism_config/setup_s3_client' | ||
| # require_relative 'exercism_config/retrieve_config' | ||
| # require_relative 'exercism_config/retrieve_secrets' | ||
|
|
||
| # require_relative 'exercism_config/version' | ||
| # require_relative 'exercism/config' | ||
| # require_relative 'exercism/secrets' | ||
| # require_relative 'exercism/tooling_job' |
| @@ -31,6 +31,7 @@ def test_config_for_production | |||
| def test_config_for_development | |||
| Exercism.stubs(env: ExercismConfig::Environment.new(:development)) | |||
| config = ExercismConfig::RetrieveConfig.() | |||
| p config | |||
There was a problem hiding this comment.
Was it intentional to add this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ErikSchierboom Could you add matrix testing to this please.