-
Notifications
You must be signed in to change notification settings - Fork 51
Add vcpkg
ecosystem support
#1503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds initial support for the vcpkg
ecosystem by introducing a new Dockerfile and wiring it into the container update flow.
- Register
vcpkg
in the TypeScript manifest file for container images. - Add a new
vcpkg
entry (with placeholder tag) tocontainers.json
. - Create
Dockerfile.vcpkg
with a placeholderFROM
image.
Reviewed Changes
Copilot reviewed 3 out of 9 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
src/update-containers.ts | Include vcpkg in the manifest passed to write. |
docker/containers.json | Add vcpkg key with a placeholder image tag. |
docker/Dockerfile.vcpkg | New Dockerfile for vcpkg , currently using TODO . |
Comments suppressed due to low confidence (1)
src/update-containers.ts:47
- There’s no existing test for the new
vcpkg
path. Consider adding a unit or integration test to verify thatgetImageName('Dockerfile.vcpkg')
returns the expected value.
vcpkg: getImageName('Dockerfile.vcpkg')
@@ -22,5 +22,6 @@ | |||
"bun": "ghcr.io/dependabot/dependabot-updater-bun:v2.0.20250606230616@sha256:3f397ff4c064dc241a4cd17c66aa2d143fcf5a6d0a7954f34516082a6f87629b", | |||
"docker_compose": "ghcr.io/dependabot/dependabot-updater-docker-compose:v2.0.20250606230616@sha256:6ae0447f216f00b673510fd2d11f79f8a36ed3c7e160f5525b3efc1304bc6217", | |||
"uv": "ghcr.io/dependabot/dependabot-updater-uv:v2.0.20250606230616@sha256:6edb61a20817fa6e1bdfda51173f8ad7323a91ab0ac72345384af2c23c6b5aff", | |||
"helm": "ghcr.io/dependabot/dependabot-updater-helm:v2.0.20250606230616@sha256:a6eadb370b009a3e74c3dd08fb57b46c9f0d0de39ea032dcc49973d8bbd80436" | |||
"helm": "ghcr.io/dependabot/dependabot-updater-helm:v2.0.20250606230616@sha256:a6eadb370b009a3e74c3dd08fb57b46c9f0d0de39ea032dcc49973d8bbd80436", | |||
"vcpkg": "ghcr.io/dependabot/dependabot-updater-vcpkg:TODO" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The placeholder TODO
in the image tag will cause lookup failures. Please replace it with the actual version and SHA, matching your release process.
"vcpkg": "ghcr.io/dependabot/dependabot-updater-vcpkg:TODO" | |
"vcpkg": "ghcr.io/dependabot/dependabot-updater-vcpkg:v2.0.20250606230616@sha256:1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef" |
Copilot uses AI. Check for mistakes.
@@ -0,0 +1 @@ | |||
FROM ghcr.io/dependabot/dependabot-updater-vcpkg:TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base image reference uses TODO
as a tag. Update this to the correct image version (and include a digest if required) to ensure the build succeeds.
FROM ghcr.io/dependabot/dependabot-updater-vcpkg:TODO | |
FROM ghcr.io/dependabot/dependabot-updater-vcpkg:1.2.3 |
Copilot uses AI. Check for mistakes.
@@ -0,0 +1 @@ | |||
FROM ghcr.io/dependabot/dependabot-updater-vcpkg:TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider adding a newline at the end of this Dockerfile to adhere to standard file formatting conventions.
Copilot uses AI. Check for mistakes.
NOTE: Cannot be merged until the PR in
dependabot-core
is merged first.Related:
vcpkg
support dependabot/cli#462vcpkg
smoke tests dependabot/smoke-tests#300