x/tools/gopls: SEGV in HasSuffix (corrupt string)

[adonovan]

#!stacks
"sigpanic" && "memeqbody" && "strings.HasSuffix" && "cache.(*Snapshot).clone:+72"

Issue created by stacks.

More memory corruption.

This stack miiHpQ was reported by telemetry:

• crash/crash
• runtime.throw:+9
• runtime.sigpanic:+33
• .memeqbody:+35
• internal/stringslite.HasSuffix:=21
• strings.HasSuffix:=467
• golang.org/x/tools/gopls/internal/cache.(*Snapshot).clone:+72
• golang.org/x/tools/gopls/internal/cache.(*Session).invalidateViewLocked:+25
• golang.org/x/tools/gopls/internal/cache.(*Session).DidModifyFiles:+158
• golang.org/x/tools/gopls/internal/server.(*server).didModifyFiles:+36
• golang.org/x/tools/gopls/internal/server.(*server).DidOpen:+20
• golang.org/x/tools/gopls/internal/protocol.serverDispatch:+253
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5
• golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52
• golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:+2
• golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:+3
• runtime.goexit:+0

golang.org/x/tools/gopls@v0.18.1 go1.23.5 darwin/arm64 other,vscode-insiders (1)

[gabyhelp]

Related Issues

• x/tools/gopls: nil deref in x/telemetry/internal/counter.(*Counter).add #73890
• x/tools/gopls: crash in append (invalid string data pointer) #73586
• x/tools/gopls: nil deref in 'go vendor' Snapshot.GoCommandInvocation #73891
• x/tools/gopls: Rename: crash due to Info.Defs[id]=nil bug in checkStructField #70968 (closed)
• x/tools/gopls: automated issue report (crash) #40449 (closed)
• x/tools/gopls: analysisinternal.ZeroValue crash on (presumably) unsafe.Pointer #70585 (closed)
• x/tools/gopls: Hover: nil deref in golang.StdSymbolOf #70969 (closed)
• x/tools/gopls: SEGV accessing map[string]... #73387
• x/tools/gopls: Hover: nil deref in parseDocLink #70635 (closed)
• x/tools/gopls: Completion: nil deref in expectedCompositeLiteralType #72136 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}