-
-
Notifications
You must be signed in to change notification settings - Fork 431
fix incorrect namespacing applied to Redis hash field keys #765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #765 +/- ##
========================================
+ Coverage 37.9% 38.0% +0.1%
========================================
Files 44 44
Lines 3253 3257 +4
Branches 244 244
========================================
+ Hits 1231 1235 +4
Misses 1778 1778
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
should I look into something specific about the GitHub CI failure? @WisdomPill |
hello @2ykwang, thanks for your contribution! so only changelog and ruff are left to fix:
|
I’ve added the changelog @WisdomPill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I wonder how tests didn't break. Could you try using different version and checking the key in the tests?
Also please fix ruff's error
also FYI, there's no need to mention me in a comment, just ask for a review, I will see the notifications and I will be happy to review 😄 |
because |
e87f1bb
to
a3e4b2a
Compare
Updated the ruff lint.ignore settings to include inline documentation links for each ignored rule. Also added "A004", "A005"
a3e4b2a
to
a3a4665
Compare
This changes addresses an issue where namespacing was applied to the field instead of the key.
behavior: