Skip to content

added 'help wanted sheild' #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 23, 2021
Merged

Conversation

san-coding
Copy link
Contributor

@san-coding san-coding commented Sep 21, 2021

Signed-off-by: Sandeep Rajakrishnan sandur43@gmail.com

Description

This PR fixes issue opened in layer5 repo : LINK TO ISSUE

  • Add help wanted shield showing help wanted count across org:layer5io org:meshery org:service-mesh-performance org:service-mesh-patterns
  • Edit contributors shield to show contributors count across org:layer5io org:meshery org:service-mesh-performance org:service-mesh-patterns or include the count from layer5io/layer5 and meshery/meshery repos
  • Add the twitter accounts for mesheryio and smp_spec in addition to the layer5 twitter shield.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sandeep Rajakrishnan <sandur43@gmail.com>
@san-coding
Copy link
Contributor Author

san-coding commented Sep 21, 2021

@leecalcote @warunicorn19
I have opened the PR here, have added help wanted shield , will figure out and do the next 2 tasks now

  • After completing the task 1, the readme looks like this

image

@warunicorn19
Copy link
Member

Alright sounds good. @san-coding

@san-coding
Copy link
Contributor Author

Alright sounds good. @san-coding

Thanks, working on the next 2 tasks on this PR

@warunicorn19
Copy link
Member

@leecalcote who has access to this repo? can't seem to add reviewers.😅

@san-coding
Copy link
Contributor Author

@leecalcote who has access to this repo? can't seem to add reviewers.😅

what would be the query for contributors @leecalcote @warunicorn19

@warunicorn19
Copy link
Member

@debo19, i'll let you take this question.

Signed-off-by: Sandeep Rajakrishnan <sandur43@gmail.com>
@san-coding
Copy link
Contributor Author

san-coding commented Sep 21, 2021

The existing twitter when clicked was redirecting to repo, instead of twitter, fixed that @leecalcote @warunicorn19 , will now add the twitter handle for mesheryio and smp_spec

Signed-off-by: Sandeep Rajakrishnan <sandur43@gmail.com>
@san-coding
Copy link
Contributor Author

san-coding commented Sep 21, 2021

Tast 2 done, added all twitter handles @leecalcote @warunicorn19

Signed-off-by: Sandeep Rajakrishnan <sandur43@gmail.com>
@debo19
Copy link
Member

debo19 commented Sep 21, 2021

@san-coding can you send a screenshot of the latest updates?

@san-coding
Copy link
Contributor Author

@san-coding can you send a screenshot of the latest updates?

Sure, now I have added count sheilds for layer5io/layer5 and meshery/meshery

Here is how it looks now

image

@debo19

@san-coding
Copy link
Contributor Author

san-coding commented Sep 21, 2021

@leecalcote @warunicorn19 @debo19 are the changes fine ?

@debo19
Copy link
Member

debo19 commented Sep 21, 2021

@san-coding Looks good but it'll be great if we could combine all contributors into one shield called "contributors". Otherwise just let the org with maximum number of contributors be present at the moment under label = "contributors". We'll add the individual contributors in the Organization section.

@san-coding
Copy link
Contributor Author

Yeah how do I write a query to get total contributors ? @debo19 @leecalcote

@san-coding
Copy link
Contributor Author

@debo , where can I find the list of total contributors to all orgs and repos

@debo19
Copy link
Member

debo19 commented Sep 22, 2021

@san-coding For Layer5 here: https://github.com/layer5io/layer5/graphs/contributors . Similarly you can find for the other repos.

@debo
Copy link

debo commented Sep 22, 2021

@san-coding always remember to double check who you tag 😉

@san-coding
Copy link
Contributor Author

@san-coding always remember to double check who you tag 😉

Oops, sorry 😓

@san-coding
Copy link
Contributor Author

@san-coding For Layer5 here: https://github.com/layer5io/layer5/graphs/contributors . Similarly you can find for the other repos.

umm... unable to figure out a way to convert it into a GitHub custom search query @debo19 @warunicorn19 @leecalcote

@leecalcote
Copy link
Member

@leecalcote who has access to this repo? can't seem to add reviewers.😅

@warunicorn19 good catch. This new repo had not been added to the layer5-contributors team as having triage permission. Those permissions have been updated now.

@leecalcote
Copy link
Member

Heads-up: a merge conflict to resolve - https://github.com/layer5io/.github/pull/6/conflicts

@leecalcote leecalcote added the kind/enhancement Improvement in current feature label Sep 23, 2021
@san-coding
Copy link
Contributor Author

Heads-up: a merge conflict to resolve - https://github.com/layer5io/.github/pull/6/conflicts

Will resolve soon

@san-coding
Copy link
Contributor Author

@leecalcote have resolved merge conflict as per @debo19 's suggestion

@san-coding Looks good but it'll be great if we could combine all contributors into one shield called "contributors". Otherwise just let the org with maximum number of contributors be present at the moment under label = "contributors". We'll add the individual contributors in the Organization section.

@san-coding
Copy link
Contributor Author

This is how it looks now, @debo19 @leecalcote
image

Copy link
Member

@debo19 debo19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thanks @san-coding

@debo19 debo19 merged commit d58a989 into layer5io:master Sep 23, 2021
@welcome
Copy link

welcome bot commented Sep 23, 2021

Thanks for your contribution to the Layer5 community! 🎉

Congrats!
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

@leecalcote
Copy link
Member

Yay! 🎈

@san-coding
Copy link
Contributor Author

Yay! 🎈

Thanks @leecalcote @warunicorn19 @debo19 , looking forward to more contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement in current feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants