Skip to content

Added phrases #5761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added phrases #5761

wants to merge 5 commits into from

Conversation

hargunkaur286
Copy link
Member

@hargunkaur286 hargunkaur286 commented Aug 1, 2024 •
edited
Loading

Description
Changes made in the following files:

  1. In https://layer5.io/cloud-native-management/meshery page:
Cloud Native Application Management Manage your clusters with features you won't find
  1. In https://layer5.io/cloud-native-management/meshmap page:
Step aside, YAML
  1. In https://layer5.io/cloud-native-management/catalog page:
CREATE AND SHARE YOUR OWN

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@hargunkaur286
added phrases at different places
a749288 
Signed-off-by: Hargun Kaur <hargunkaur286@gmail.com>
@l5io
Copy link
Contributor

l5io commented Aug 1, 2024

🚀 Preview for commit a749288 at: https://66ac11228362b37c8952e120--layer5.netlify.app

ashparshp
ashparshp reviewed Aug 2, 2024
View reviewed changes
src/sections/Meshery/index.js Outdated
@@ -62,6 +62,7 @@ const MesheryPage = () => {
image={Nic} />
<div className="callout">
<h1> Manage your clusters with features you won't find anywhere else.</h1>
<h4><strong>Illustrate key concepts with visuals. </strong>Use diagrams, charts, or images to help users grasp complex ideas quickly.</h4>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about making it italic? It doesn't look good here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or perhaps not using a strong tag?

@ashparshp
Copy link
Contributor

@hargunkaur286 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@ashparshp
Copy link
Contributor

ashparshp commented Aug 13, 2024 •
edited
Loading

@hargunkaur286, any updates on this? How are we going to proceed with it, or is it on hold?

@sudhanshutech
Copy link
Member

@hargunkaur286 please make the updates here as requested.

@hargunkaur286
added changes
bcee8ab 
Signed-off-by: Hargun Kaur <hargunkaur286@gmail.com>
@hargunkaur286
added changes
29a5642 
Signed-off-by: Hargun Kaur <hargunkaur286@gmail.com>
@l5io
Copy link
Contributor

l5io commented Aug 17, 2024

🚀 Preview for commit 29a5642 at: https://66c0aece9b90ff7b2bd8d4a3--layer5.netlify.app

@hargunkaur286
added changes
b3e3282 
Signed-off-by: Hargun Kaur <hargunkaur286@gmail.com>
@hargunkaur286
Copy link
Member Author

  1. In https://layer5.io/cloud-native-management/catalog page:
Screenshot 2024-08-17 at 7 43 27 PM
  1. In https://layer5.io/cloud-native-management/meshmap
Screenshot 2024-08-17 at 7 44 32 PM
  1. In https://layer5.io/cloud-native-management/playground
Screenshot 2024-08-17 at 7 46 33 PM

@l5io
Copy link
Contributor

l5io commented Aug 17, 2024

🚀 Preview for commit b3e3282 at: https://66c0b257d9e6ac7d77738ff9--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

Thank you @hargunkaur286

  1. Playground page ✔️
    image

^^ Looks good to me

  1. Catalog Page:
    image
    I'm not sure if the added phrase fits into the context (CREATE AND SHARE YOUR OWN BEST PRACTICES)
  1. MeshMap page [Your screenshot]
    image

for the meshmap page, I wonder if adding the phrase next to the already long description fails to make it stand out as intended.
Note: https://66c0aece9b90ff7b2bd8d4a3--layer5.netlify.app/cloud-native-management/meshmap I can't see the added phrase in preview.

@vishalvivekm
Copy link
Contributor

Also, getting one / more of these phrases on Homepage would be nice.

@hargunkaur286
added changes
007dfd3 
Signed-off-by: Hargun Kaur <hargunkaur286@gmail.com>
@l5io
Copy link
Contributor

l5io commented Aug 19, 2024

🚀 Preview for commit 007dfd3 at: https://66c32e325b098bb2ecea1e34--layer5.netlify.app

@hargunkaur286
Copy link
Member Author

Screenshot 2024-08-19 at 5 52 32 PM Screenshot 2024-08-19 at 5 53 10 PM

@vishalvivekm
Copy link
Contributor

merge conflicts.

@leecalcote leecalcote reopened this Nov 24, 2024
@leecalcote leecalcote removed the request for review from vishalvivekm December 21, 2024 15:02
@stale Stale
Copy link

stale bot commented Apr 26, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 26, 2025
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashparshp ashparshp ashparshp left review comments

@leecalcote leecalcote Awaiting requested review from leecalcote

@sudhanshutech sudhanshutech Awaiting requested review from sudhanshutech

Assignees
No one assigned
Labels
issue/willfix project/kanvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hargunkaur286 @l5io @ashparshp @sudhanshutech @vishalvivekm @leecalcote