Skip to content

[Sistent] Add Switch component to the sistent components page #6380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

M-DEV-1
Copy link
Member

@M-DEV-1 M-DEV-1 commented Apr 9, 2025

Description

This PR fixes #5960

I've added the Switch component to the Sistent Components page with code examples, usage and guidance.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

M-DEV-1 added 2 commits April 9, 2025 19:25
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@l5io
Copy link
Contributor

l5io commented Apr 9, 2025

🚀 Preview for commit 3a4450c at: https://67f68128b244c6f132e32a86--layer5.netlify.app

@vr-varad
Copy link
Contributor

vr-varad commented Apr 9, 2025

  1. Could Increase Visibility
    image
  2. Missing Tabs
    image
  3. Could Be aligned
    image

@vr-varad
Copy link
Contributor

vr-varad commented Apr 9, 2025

Hey @M-DEV-1 some fixes

@M-DEV-1
Copy link
Member Author

M-DEV-1 commented Apr 9, 2025

Thanks @vr-varad for pointing these out, I'll fix them 🤝

I'm not sure what you meant by 3., but I will be adding more switches in the same code block for better representation.

@vr-varad
Copy link
Contributor

vr-varad commented Apr 9, 2025

Thanks @vr-varad for pointing these out, I'll fix them 🤝

I'm not sure what you meant by 3., but I will be adding more switches in the same code block for better representation.

I meann't I would look good if they were side by side but nevermind

@M-DEV-1
Copy link
Member Author

M-DEV-1 commented Apr 9, 2025

Thanks @vr-varad for pointing these out, I'll fix them 🤝
I'm not sure what you meant by 3., but I will be adding more switches in the same code block for better representation.

I meann't I would look good if they were side by side but nevermind

Yes, you're right. It would be better side by side, in the same block. I'll make those changes. Thanks.

@vishalvivekm
Copy link
Contributor

@M-DEV-1
Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST

Add it as an agenda item to the meeting minutes, if you would :)

@vishalvivekm
Copy link
Contributor

Thank you for @vr-varad offering feedback here, 👏

@l5io
Copy link
Contributor

l5io commented Apr 14, 2025

🚀 Preview for commit 8f0d5d4 at: https://67fcc9f59f81bdc6026cd179--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@M-DEV-1 are all the suggestions in here by @vr-varad and during last sites' call, incorporated?

@l5io
Copy link
Contributor

l5io commented Apr 21, 2025

🚀 Preview for commit ff3b43d at: https://680627b848abe9f284a11437--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

Thank you @Souradip121 for making these changes, however, a couple of them are still in need of being included in here.

@sudhanshutech
Copy link
Member

sudhanshutech commented Apr 29, 2025

it looks good to me @vishalvivekm @amitamrutiya

Copy link

stale bot commented Jun 27, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jun 27, 2025
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jun 28, 2025
@@ -0,0 +1,131 @@
import React, { useState } from "react";
import { CodeBlock } from "../button/code-block";
import { Switch, FormControlLabel, SistentThemeProvider } from "@layer5/sistent";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { Switch, FormControlLabel, SistentThemeProvider } from "@layer5/sistent";
import { Switch, FormControlLabel, SistentThemeProvider } from "@sistent/sistent";

SistentThemeProvider,
Switch,
FormControlLabel,
} from "@layer5/sistent";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} from "@layer5/sistent";
} from "@sistent/sistent";

@vishalvivekm
Copy link
Contributor

@M-DEV-1 failing build / checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sistent] Add Switch component to the sistent components page
5 participants