Skip to content

Add navigation link for kanvas section on layer5 website #6486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LibenHailu
Copy link
Contributor

@LibenHailu LibenHailu commented May 23, 2025

Description

This PR fixes #6485

Notes for Reviewers
Add navigation for kanvas section.

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented May 23, 2025

🚀 Preview for commit 25be30f at: https://6830cf744cb23a0074f8caf9--layer5.netlify.app

@M-DEV-1
Copy link
Member

M-DEV-1 commented May 24, 2025

Thank you @LibenHailu 🙌

do you have any ideas/suggestions on making this more intuitive to users? maybe changing the cursor pointer settings on hover?

is it intuitive that you can go to the docs, on-click?

these are just some general ux improvements that we could make.

let me know if you have any ideas.

@M-DEV-1
Copy link
Member

M-DEV-1 commented May 24, 2025

@LibenHailu, please sign off your commits ^^

Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
Signed-off-by: Liben Hailu <libenhailu04@gmail.com>
@LibenHailu
Copy link
Contributor Author

Hi @M-DEV-1, It is important that links are distinguishable from UX perspective, there are many approach to take for that like underlined text to tell to users it is not text it is a link or using cursor pointer style or putting link icons aside, for our case we can definitely go with the cursor pointer style, one major problem can be this is not applied on mobile screens, hoping out users are developers in my opinion if we go with the cursor: pointer style we will be good.

I think linking the docs there is a good UX improvement, from user perspective, I dont have any additions on this at the moment.

@l5io
Copy link
Contributor

l5io commented May 24, 2025

🚀 Preview for commit ac040e3 at: https://6831821c47913f457d1c8a9e--layer5.netlify.app

@M-DEV-1
Copy link
Member

M-DEV-1 commented May 26, 2025

Hi @LibenHailu, small spelling error to fix
image

@M-DEV-1
Copy link
Member

M-DEV-1 commented May 28, 2025

hi @LibenHailu, have you incorporated the feedback given earlier?

@M-DEV-1
Copy link
Member

M-DEV-1 commented Jun 4, 2025

@LibenHailu, any updates?

@M-DEV-1
Copy link
Member

M-DEV-1 commented Jun 4, 2025

25be30f

This commit is causing the DCO check to fail ^^

@LibenHailu
Copy link
Contributor Author

@LibenHailu, any updates?
@M-DEV-1 I am having an issue running the project, we are planning to gather the number of the people who are having the issue, and we are planning to come-up with a work-around for the issue if the number is big, we also collect what is working for people, so far I think it is codespaces which I don't have access to at the moment.

@vr-varad
Copy link
Contributor

vr-varad commented Jun 4, 2025

why dont u put that issue in slack?? @LibenHailu

@LibenHailu
Copy link
Contributor Author

LibenHailu commented Jun 4, 2025

why dont u put that issue in slack?? @LibenHailu

I was thinking about sending a poll on slack, the bot should be installed I reached out to some people, I will do it as soon as I get access to the poll, The idea is to know how many people are struggling to contribute due to the heavy contents we have, the question might look like Are you having an issue running the project, the choices will be yes and no, that way we can know the magnitude of the problem, in quantifiable amount, what do you think @vr-varad ?

@M-DEV-1
Copy link
Member

M-DEV-1 commented Jun 4, 2025

I was thinking about sending a poll on slack, the bot should be installed I reached out to some people, I will do it as soon as I get access to the poll, The idea is to know how many people are struggling to contribute due to the heavy contents we have, the question might look like Are you having an issue running the project, the choices will be yes and no, that way we can know the magnitude of the problem, in quantifiable amount, what do you think @vr-varad ?

Hmm, okay. That works too. If you have a student ID, you should claim GitHub PRO and use 32 GB codespaces. Let's see what can be done for now. Message in #support with the exact issue, and the issue after trying out selective rendering.

@vr-varad
Copy link
Contributor

vr-varad commented Jun 4, 2025

@LibenHailu Discuss that in todays' meet

@LibenHailu
Copy link
Contributor Author

@LibenHailu Discuss that in todays' meet

Sorry @vr-varad I am just seeing this.

@LibenHailu
Copy link
Contributor Author

ort with the exact issue, and the issue after trying out selective rendering.

But I will post on support, unforunately I dont have student ID.

@M-DEV-1
Copy link
Member

M-DEV-1 commented Jun 25, 2025

@LibenHailu are you able to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add navigation links to relevant documentation on Kanvas section of layer5.io
4 participants