fix(ScenarioCard): adjust height properties and correct typos #6527
Conversation
|
🚀 Preview for commit d634f65 at: https://684182f1e33c30aed7166469--layer5.netlify.app |
|
Hi @DEEP-600, thank you for your contribution! There's no need for the comments, as Git helps us track the changes made. Other than that, it looks good to me (LGTM). Reviewers can remove the comments before merging. |
Signed-off-by: deep <www.crushy@gmail.com>
|
🚀 Preview for commit c52be91 at: https://6841d1690c73d9605dd533ca--layer5.netlify.app |
Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
|
🚀 Preview for commit 61d3f1c at: https://68465b51a590ccfeb05d0a27--layer5.netlify.app |
| width: 100%; | ||
| height: 100%; | ||
| height: auto; |
There was a problem hiding this comment.
a circular dependency here, setting parent's (.open-animate) height to auto and then giving child (.active) a height of 100%. Llet's just simply remove the hardcoded height and make parent a flex container
Signed-off-by: Vivek Vishal <vishalvivek488@gmail.com>
|
@DEEP-600 Add it as an agenda item to the meeting minutes, if you would :) |
This PR fixes #6384.
It resolves the issue of excessive vertical space in the expanded sections of the Service Mesh Labs page.
The height property for the .active and .open-animate classes in ScenarioCard.style.js has been changed from a fixed value to auto.
This allows the expanded content to dynamically adjust its height based on its contents, thereby correcting the layout issue and enhancing the overall user experience.
layer.-.card.-.responsiveness.mp4