-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix: issue #6538 Overlapping Content on HandBook TOC #6550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix: issue #6538 Overlapping Content on HandBook TOC #6550
Conversation
🚀 Preview for commit 6864d8a at: https://684ddaa7c5658ea4cea0868f--layer5.netlify.app |
b38b5ec
to
7e626b9
Compare
Signed-off-by: Wyllie Fang <wylliefang@gmail.com>
🚀 Preview for commit 7e626b9 at: https://684ddfd3a49b72b3aa3d086c--layer5.netlify.app |
7e626b9
to
b62fe03
Compare
🚀 Preview for commit b62fe03 at: https://684de38ab54488b74aaa3950--layer5.netlify.app |
Hi @Vincamine, |
🚀 Preview for commit 2b7e1a7 at: https://684f3ea1a49b7240993d076b--layer5.netlify.app |
Signed-off-by: Wyllie Fang <wylliefang@gmail.com>
2b7e1a7
to
91e6693
Compare
Hi @LibenHailu. I’ve refined the solution by 1.Defining the layout behavior for screens under 750px 2.Replacing the existing mobile media query with a more robust version. As for reducing the space, seems like there are same layout pattern on other pages due to their content structure. I’d be happy to implement a more global fix if that’s helpful |
🚀 Preview for commit 91e6693 at: https://684f5e31ffd5140380a46808--layer5.netlify.app |
🚀 Preview for commit 91e6693 at: https://684f6110f153d1bbed94c49a--layer5.netlify.app |
Hi @Vincamine, do you join today's sites meeting, Let's discuss this during the websites call today. |
@Vincamine Add it as an agenda item to the meeting minutes, if you would :) |
Hi guys! the time zone doesn’t quite work for me.. But I’m really curious if there were any updates or insights on the issue. Happy to catch up via notes or async! |
Hi @Vincamine , Can you join next sites meeting if you are able to, if not we can have a discussion offline? |
@Vincamine the changed page looks much better 👍🏼 some pages still have some gap though, a global fix would be nice, along with some horizontal padding for mobile view on these pages. were you able to find the theme breakpoints? |
@Vincamine any update on this?? |
Description
This PR fixes #6538 [UI] Overlapping Content on HandBook Repository OverView.
Notes for Reviewers


Here are screenshots showing the fix. Adjustments are now media-query scoped to prevent layout shift.
Signed commits