Skip to content

Fix: issue #6538 Overlapping Content on HandBook TOC #6550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Vincamine
Copy link

@Vincamine Vincamine commented Jun 14, 2025

Description

This PR fixes #6538 [UI] Overlapping Content on HandBook Repository OverView.

Notes for Reviewers
Here are screenshots showing the fix. Adjustments are now media-query scoped to prevent layout shift.
Screenshot 2025-06-14 at 12 58 55 PM
Screenshot 2025-06-14 at 12 59 23 PM

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Jun 14, 2025

🚀 Preview for commit 6864d8a at: https://684ddaa7c5658ea4cea0868f--layer5.netlify.app

@Vincamine Vincamine force-pushed the wyllie-fix-6538-overlapping-content branch from b38b5ec to 7e626b9 Compare June 14, 2025 20:35
Signed-off-by: Wyllie Fang <wylliefang@gmail.com>
@l5io
Copy link
Contributor

l5io commented Jun 14, 2025

🚀 Preview for commit 7e626b9 at: https://684ddfd3a49b72b3aa3d086c--layer5.netlify.app

@Vincamine Vincamine force-pushed the wyllie-fix-6538-overlapping-content branch from 7e626b9 to b62fe03 Compare June 14, 2025 20:50
@l5io
Copy link
Contributor

l5io commented Jun 14, 2025

🚀 Preview for commit b62fe03 at: https://684de38ab54488b74aaa3950--layer5.netlify.app

@LibenHailu
Copy link
Contributor

Hi @Vincamine,
Thank you for your contribution! We refrain from using media queries as much as possible, There are theme breakpoints I couldn't locate them, I think @M-DEV-1 can help us here, Would it be possible to reduce the space on the image below by any chance 😇 ?
Screenshot-9

@l5io
Copy link
Contributor

l5io commented Jun 15, 2025

🚀 Preview for commit 2b7e1a7 at: https://684f3ea1a49b7240993d076b--layer5.netlify.app

Signed-off-by: Wyllie Fang <wylliefang@gmail.com>
@Vincamine Vincamine force-pushed the wyllie-fix-6538-overlapping-content branch from 2b7e1a7 to 91e6693 Compare June 15, 2025 23:46
@Vincamine
Copy link
Author

Vincamine commented Jun 15, 2025

Hi @LibenHailu. I’ve refined the solution by 1.Defining the layout behavior for screens under 750px 2.Replacing the existing mobile media query with a more robust version. As for reducing the space, seems like there are same layout pattern on other pages due to their content structure. I’d be happy to implement a more global fix if that’s helpful

@Vincamine Vincamine closed this Jun 15, 2025
@Vincamine Vincamine reopened this Jun 15, 2025
@l5io
Copy link
Contributor

l5io commented Jun 16, 2025

🚀 Preview for commit 91e6693 at: https://684f5e31ffd5140380a46808--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jun 16, 2025

🚀 Preview for commit 91e6693 at: https://684f6110f153d1bbed94c49a--layer5.netlify.app

@LibenHailu
Copy link
Contributor

Hi @Vincamine, do you join today's sites meeting, Let's discuss this during the websites call today.

@vishalvivekm
Copy link
Contributor

@Vincamine
Thank you for your contribution!
Let's discuss this during the website call today at 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

@Vincamine
Copy link
Author

Vincamine commented Jun 17, 2025

Hi @Vincamine, do you join today's sites meeting, Let's discuss this during the websites call today.

Hi @Vincamine, do you join today's sites meeting, Let's discuss this during the websites call today.

@Vincamine Thank you for your contribution! Let's discuss this during the website call today at 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

Hi guys! the time zone doesn’t quite work for me.. But I’m really curious if there were any updates or insights on the issue. Happy to catch up via notes or async!

@LibenHailu
Copy link
Contributor

LibenHailu commented Jun 18, 2025

Hi guys! the time zone doesn’t quite work for me.. But I’m really curious if there were any updates or insights on the issue. Happy to catch up via notes or async!

Hi @Vincamine , Can you join next sites meeting if you are able to, if not we can have a discussion offline?

@M-DEV-1
Copy link
Member

M-DEV-1 commented Jun 19, 2025

@Vincamine the changed page looks much better 👍🏼

some pages still have some gap though, a global fix would be nice, along with some horizontal padding for mobile view on these pages.

were you able to find the theme breakpoints?

@vr-varad
Copy link
Contributor

@Vincamine any update on this??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Overlapping Content on HandBook Repository OverView.
6 participants