Skip to content

Replace LearnServiceMeshCTA with KanvasCTA across site #6569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Ayushmore1214
Copy link

Description
I have made changes asked accordingly in the issue
This PR fixes #6556

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Ayush More <ayushmore42595@gmail.com>
@Ayushmore1214 Ayushmore1214 force-pushed the replace-learnservice-cta branch from 3384e93 to e484d73 Compare June 20, 2025 11:04
@vr-varad vr-varad requested a review from LibenHailu June 20, 2025 11:09
@Ayushmore1214
Copy link
Author

Can someone review my code and tell me what's wrong

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes has to be made to this CTA. The ask is to simply replace its occurrence with any other CTA like KanvasCTA.

Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayushmore1214 I wonder if you have invested time to build your changes here? multiple broken reference to assets / components, resulting in failing build.

Please remove changes from package-lock and package.json files
Marking it as on/hold, please feel free to mark it as ready when it is.

@vishalvivekm vishalvivekm added pr/hold Do not merge this PR pr/draft labels Jun 22, 2025
@vishalvivekm
Copy link
Contributor

@Ayushmore1214
Have updates to share?
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

@Ayushmore1214
Copy link
Author

I'm working on this and will raise a PR soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Call To Action
2 participants