Skip to content

fix: Support level ribbon overlaps design title #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

FaheemOnHub
Copy link
Contributor

@FaheemOnHub FaheemOnHub commented Jun 3, 2025

This PR fixes https://github.com/layer5io/meshery-cloud/issues/3534

will dynamically adjust whether card has a ribbion or not.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: TheFaheem <faheemmushtaq89@gmail.com>
@FaheemOnHub FaheemOnHub requested a review from leecalcote June 4, 2025 14:52
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I suspect that these changes need to go into the component in Sistent, though. Is that right?

// @vr-varad @vishalvivekm @M-DEV-1 @aabidsofi19

Copy link
Contributor

@amitamrutiya amitamrutiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@amitamrutiya amitamrutiya merged commit fb77e52 into layer5io:master Jun 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants