Changing what LatestRelease recognizes as the latest release or latest snapshot keyword versions by expanding it to include those from Ivy/Gradle
#5720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-aom-elliott
added
bug
timtebeek
reviewed
Jul 5, 2025
| @Test | ||
| void retainLatestReleaseOrLatestIntegrationIfUsed() { | ||
| rewriteRun( | ||
| spec -> spec.recipe(new UpgradeDependencyVersion("org.projectlombok", "lombok", "1.18.*", null)), |
There was a problem hiding this comment.
Adding the context here that this is coming from in org.openrewrite.java.migrate.lombok.UpdateLombokToJava11.
timtebeek
approved these changes
Jul 5, 2025
There was a problem hiding this comment.
This looks good to me already; I'm somewhat surprised we hadn't run up against this before. I'm going to chalk that up to only recently having added support for .kts files which our own projects use alongside latest.release.
Given the potential for impact I'm going to ask for a quick review from @jkschneider to resolve this customer issue.
steve-aom-elliott
force-pushed
the
steve-fix-recognition-of-latest-release-latest-integration-for-upgrading
branch
from
e754744 to
e860733
Compare
…est snapshot keyword versions by expanding it to include those from Ivy/Gradle
steve-aom-elliott
force-pushed
the
steve-fix-recognition-of-latest-release-latest-integration-for-upgrading
branch
from
e860733 to
70434be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
LatestReleaseto not only recognizeLATESTandRELEASEfrom Maven, but also their equivalents from Ivy / Gradle (latest.integrationandlatest.release)What's your motivation?
We were seeing
UpgradeDependencyVersionfor Gradle changelatest.releaseto a specific version number rather than leaving it alone.Checklist