Skip to content

[PyMySQL] Fix issue with import constants attributes #14393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025

Conversation

donBarbos
Copy link
Contributor

Related: #14392

This comment has been minimized.

@srittau
Copy link
Collaborator

srittau commented Jul 10, 2025

In fact, according to microsoft/pyright#10690, this is actually a bug in pyright. Closing this here.

@srittau srittau closed this Jul 10, 2025
@srittau srittau reopened this Jul 10, 2025
@srittau
Copy link
Collaborator

srittau commented Jul 10, 2025

Reopening. @donBarbos Could you change this to ... as ... consistently? While it doesn't fix the original issue, I think it's more correct. (Although not strictly necessary, as they are mentioned in __all__.)

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit df3b5f3 into python:main Jul 10, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants