Add test for default_field_values and const_default
#143649
Open
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
17 tasks
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
const-trait-default-field-value
branch
from
1e61f8a to
6b7845f
Compare
Add a test showing `#![feature(default_field_values)]` using `#[const_trait] trait Default` (`#![feature(const_default)]` + `#![feature(const_trait_impl)]`).
estebank
force-pushed
the
const-trait-default-field-value
branch
from
6b7845f to
01c88e8
Compare
fmease
reviewed
Jul 8, 2025
| // Ensure that `default_field_values` and `const_default` interact properly. | ||
|
|
||
| #![feature(default_field_values)] | ||
| #![feature(const_trait_impl)] |
There was a problem hiding this comment.
Do you think it would be worthwhile to also test default field values (set to a Default::default() like here) where the struct init is at comptime (e.g., using const { ... }#[derive_const]) or is this already covered somewhere else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test showing
#![feature(default_field_values)]using#[const_trait] trait Default(#![feature(const_default)]+#![feature(const_trait_impl)]).CC #132162