-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aipc, an async ipc library for aero #60
base: master
Are you sure you want to change the base?
Conversation
I'm not a fan of all these |
I could possibly move them to The unwraps are there because I explicitly wanted to prevent injecting |
|
||
|
||
fn main() { | ||
let mut rt = aipc::async_runtime::AsyncRuntime::new(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of constructing a runtime manually at the start of the main function, it would be a much cleaner idea to initialize it lazily in the spawn function instead. So it will look like apic::spawn(async {})
. In future we; after we get the rust userland port sorted out we can switch to using tokio
as our async runtime.
b2b7b40
to
711c1ec
Compare
f320b00
to
e98c22d
Compare
5b4b6dd
to
6defcde
Compare
ebad1c8
to
f1ba94d
Compare
90094ea
to
5222520
Compare
1de1b56
to
f7cd1a0
Compare
51c9079
to
9105725
Compare
936f430
to
f275662
Compare
'nuff said.