Skip to content

[Fluent] Move useDegrees into RotationVectorPropertyLine; update how dropdown accepts undefined; rename BoundProperty #16811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025

Conversation

georginahalpern
Copy link
Contributor

  • Rename BoundPropertyLine to BoundProperty
  • Move the useDegrees concept outside of syncedslider/vectorpropertyline and keep it only within RotationVectorPropertyLine
  • Change how dropdown accepts undefined values -- the component will supply the 'undefined' value directly
  • Add stub for transparentmaterial in iv2 to test the above dropdown logic
  • Remove the colorsliders/vectorsliders components and just render the fragment directly within the propertylines to reduce complexity

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 25, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@sebavan sebavan requested a review from ryantrem June 25, 2025 20:38
@bjsplat
Copy link
Collaborator

bjsplat commented Jun 25, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16811/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 25, 2025

Building or testing the sandbox has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16811/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 25, 2025

Graph tools CI has failed you can find the test results at:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16811/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 25, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 25, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 25, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16811/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16811/merge/?snapshot=refs/pull/16811/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 25, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16811/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 25, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jun 25, 2025

@georginahalpern georginahalpern merged commit 34639bd into BabylonJS:master Jun 25, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants