-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Fluent] Move useDegrees into RotationVectorPropertyLine; update how dropdown accepts undefined; rename BoundProperty #16811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
georginahalpern
commented
Jun 25, 2025
- Rename BoundPropertyLine to BoundProperty
- Move the useDegrees concept outside of syncedslider/vectorpropertyline and keep it only within RotationVectorPropertyLine
- Change how dropdown accepts undefined values -- the component will supply the 'undefined' value directly
- Add stub for transparentmaterial in iv2 to test the above dropdown logic
- Remove the colorsliders/vectorsliders components and just render the fragment directly within the propertylines to reduce complexity
…undefined values, add stub for material in iv2
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Building or testing the playground has failed. If the tests failed, results can be found here: |
Building or testing the sandbox has failed. If the tests failed, results can be found here: |
Graph tools CI has failed you can find the test results at: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/16811/merge/testResults/ |
packages/dev/inspector-v2/src/components/properties/materialTransparencyProperties.tsx
Show resolved
Hide resolved
packages/dev/inspector-v2/src/services/panes/properties/materialPropertiesService.tsx
Outdated
Show resolved
Hide resolved
packages/dev/sharedUiComponents/src/fluent/hoc/vectorPropertyLine.tsx
Outdated
Show resolved
Hide resolved
packages/dev/sharedUiComponents/src/fluent/hoc/vectorPropertyLine.tsx
Outdated
Show resolved
Hide resolved
packages/dev/sharedUiComponents/src/fluent/primitives/dropdown.tsx
Outdated
Show resolved
Hide resolved
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16811/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16811/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16811/merge#BCU1XR#0 |
You have made possible changes to the playground. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/16811/merge/ The snapshot playground with the CDN snapshot (only when available): Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly. |
You have changed file(s) that made possible changes to the sandbox. https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/16811/merge/ |
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |