Migrate Smart Filters packages into the repo #16817
Conversation
…nd map files are correct too
… by ensuring dist has JS that has .js suffixes in the imports. Now following the existing pattern of /index instead of just / as well.
…endency for core (just for a type)
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16817/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/16817/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/16817/merge#BCU1XR#0 |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
…ion to avoid name resolution issues with eslint
…t be resolved in shader file processing
|
Reviewer - this PR has made changes to one or more package.json files. |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
| @@ -68,7 +69,7 @@ | |||
| "build:umd:libs": "nx run-many --target=build --parallel --maxParallel=6 --projects=babylonjs,babylonjs-gui,babylonjs-loaders,babylonjs-materials,babylonjs-serializers,babylonjs-post-process,babylonjs-procedural-textures,babylonjs-ktx2decoder,babylonjs-accessibility,babylonjs-addons", | |||
| "build:umd:tools": "nx run-many --target=build --parallel --maxParallel=2 --projects=babylonjs-inspector,babylonjs-node-editor,babylonjs-node-geometry-editor,babylonjs-node-render-graph-editor,babylonjs-node-particle-editor,babylonjs-gui-editor", | |||
| "build:es6": "npm run build:es6:libs && npm run build:es6:tools", | |||
| "build:es6:libs": "nx run-many --target=build --parallel --maxParallel=6 --projects=@babylonjs/core,@babylonjs/gui,@babylonjs/loaders,@babylonjs/materials,@babylonjs/serializers,@babylonjs/post-processes,@babylonjs/procedural-textures,@babylonjs/viewer,@babylonjs/shared-ui-components,@babylonjs/addons,@babylonjs/accessibility,@babylonjs/ktx2decoder", | |||
| "build:es6:libs": "nx run-many --target=build --parallel --maxParallel=6 --projects=@babylonjs/core,@babylonjs/gui,@babylonjs/loaders,@babylonjs/materials,@babylonjs/serializers,@babylonjs/post-processes,@babylonjs/procedural-textures,@babylonjs/viewer,@babylonjs/shared-ui-components,@babylonjs/addons,@babylonjs/accessibility,@babylonjs/ktx2decoder,@babylonjs/smart-filters,@babylonjs/smart-filters-blocks", | |||
| "build:es6:tools": "nx run-many --target=build --parallel --maxParallel=2 --projects=@babylonjs/node-editor,@babylonjs/node-geometry-editor,@babylonjs/node-render-graph-editor,@babylonjs/node-particle-editor,@babylonjs/inspector,@babylonjs/gui-editor", | |||
| @@ -82,7 +83,7 @@ | |||
| "watch-and-serve:dev": "concurrently \"npm run watch-dev-test\" \"npm run serve -w @tools/babylon-server\"", | |||
| "watch-lts": "npx nx run-many --target=watch:lts --all --parallel --maxParallel=20", | |||
| "build:babylonjs": "nx build babylonjs", | |||
| "build:tools": "npm run build -w @dev/build-tools && npm run build -w eslint-plugin-babylonjs", | |||
| "build:tools": "npm run build -w @dev/build-tools && npm i @dev/build-tools -D && npm run compile:assets -w @dev/core && npm run build -w eslint-plugin-babylonjs", | |||
There was a problem hiding this comment.
Should the asset part be hidden in Smart Filters ?
There was a problem hiding this comment.
This line has two changes: the first is to call "npm i" right after building build-tools - this used to be done in "prepare", but now we need to actually use the tools right away, so I call "npm i" immediately after building them.
The second change is to run "compile:assets" in @dev/core, and that's so the "build:assets" script (which is called by "prepare" next) will succeed, now that "build:assets" calls buildShaders in @dev/smart-filters which has a dependency on @dev/core which can't build unless it has built the assets already.
Does that answer your question?
| }, | ||
| "files": [ | ||
| "dist", | ||
| "src", |
There was a problem hiding this comment.
We don't typically distribute the source, right? I'm guessing in the other repo, this package did include the source, and so this is just keeping it the same?
| "appendJS": true | ||
| } | ||
| ], | ||
| "paths": { |
There was a problem hiding this comment.
Don't we use project references elsewhere?
|
|
||
| ## Debugger Browser Extension | ||
|
|
||
| This browser extension is intended to aid in the development of web applications that make use of Smart Filters. |
There was a problem hiding this comment.
Is this intended to be published to the chrome extension store, or only "side loaded"? Maybe some clarifications on this in the readme would be good.
| @@ -0,0 +1,44 @@ | |||
| # Babylon.js Smart Filters | |||
There was a problem hiding this comment.
Maybe a brief description of the purpose of this tool?
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2024 Babylon.js | |||
There was a problem hiding this comment.
nit: should it be 2025?
No description provided.