Update manifest.json #20383

capmann · 2025-05-27T11:46:48Z

Add the new monitor template for REDIS

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Add the new monitor template for REDIS

Create new monitor template for REDIS

Fixed problem with tagging

add new monitor template for redis

shorten the desc

capmann · 2025-05-27T15:19:23Z

/merge

dd-devflow · 2025-05-27T15:19:28Z

View all feedbacks in Devflow UI.

2025-05-27 15:19:27 UTC ℹ️ Start processing command /merge

2025-05-27 15:19:43 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-05-27 19:20:06 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

capmann · 2025-05-27T15:19:42Z

/merge

dd-devflow · 2025-05-27T15:19:48Z

View all feedbacks in Devflow UI.

2025-05-27 15:19:47 UTC ℹ️ Start processing command /merge

2025-05-27 15:19:56 UTC ❌ MergeQueue

PR already in the queue with status waiting

capmann · 2025-05-28T06:04:41Z

/merge

dd-devflow · 2025-05-28T06:04:44Z

View all feedbacks in Devflow UI.

2025-05-28 06:04:44 UTC ℹ️ Start processing command /merge

2025-05-28 06:04:51 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-05-28 10:05:07 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

capmann · 2025-05-29T08:37:07Z

/merge

dd-devflow · 2025-05-29T08:37:11Z

View all feedbacks in Devflow UI.

2025-05-29 08:37:10 UTC ℹ️ Start processing command /merge

2025-05-29 08:37:18 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-05-29 12:38:05 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

scott-xue-datadog · 2025-05-29T19:22:51Z

redisdb/assets/monitors/cmd_latency.json

+		"id": 173213351,
+		"name": "[Redis] High command latency (p99)",
+		"type": "query alert",
+		"query": "avg(last_5m):avg:redis.net.latency_ms.p99{integration:redis} > 20",


Are you sure this metric exists? i dont see it defined in the metadata.

also im not sure if this tag exists

Consider redis.slowlog.micros.95percentile instead?

scott-xue-datadog · 2025-05-29T19:25:15Z

redisdb/assets/monitors/cmd_latency.json

+				"critical": 20
+			},
+			"notify_audit": false,
+			"evaluation_delay": 300,


just curious, why do we need to delay evaluation?

scott-xue-datadog · 2025-05-29T19:27:20Z

redisdb/assets/monitors/error.json

+		"id": 173301042,
+		"name": "[Redis] Error rate elevated",
+		"type": "query alert",
+		"query": "avg(last_5m):avg:redis.errors.per_sec{integration:redis} > 5",


Also not sure if this metric exists OOTB, or the scope. What to group by also?

I just checked, indeed that metric doesn't seem to exist 😬 would you know of an alternative one?

scott-xue-datadog · 2025-05-29T19:27:56Z

redisdb/assets/monitors/error.json

+	"title": "Error rate is elevated",
+	"description": "This monitor tracks Redis command errors per second. It triggers when error rate exceeds 5/sec, which may indicate misconfigurations, failed AUTH attempts, or denied commands.",
+	"definition": {
+		"id": 173301042,


Dont add an id

scott-xue-datadog · 2025-05-29T19:28:06Z

redisdb/assets/monitors/cmd_latency.json

+	"title": "Command latency is high",
+	"description": "Redis is built for speed, and command latency is a key performance indicator. This monitor tracks the 99th percentile of command latency to catch slowdowns early, helping prevent cascading delays across your systems.",
+	"definition": {
+		"id": 173213351,


dont add id

Review from joepeeples is dismissed. Related teams and files:

documentation
- redisdb/assets/monitors/cmd_latency.json

Review from iliakur is dismissed. Related teams and files:

agent-integrations
- redisdb/assets/monitors/cmd_latency.json

Review from steveny91 is dismissed. Related teams and files:

agent-integrations
- redisdb/assets/monitors/cmd_latency.json

Update manifest.json

c0872c0

Add the new monitor template for REDIS

capmann requested review from a team as code owners May 27, 2025 11:46

temporal-github-worker-1 bot added ecosystems/review-requested product/review-requested labels May 27, 2025

capmann requested a review from khangtruong May 27, 2025 11:46

datadog-agent-integrations-bot bot added documentation integration/redisdb team/agent-integrations team/documentation labels May 27, 2025

khangtruong approved these changes May 27, 2025

View reviewed changes

capmann added 5 commits May 27, 2025 14:17

Create cmd_latency.json

9c227e0

Create new monitor template for REDIS

Update cmd_latency.json

d65c551

Fixed problem with tagging

Create error.json

f1bb677

add new monitor template for redis

Update manifest.json

c58f210

Update error.json

cfb4e91

shorten the desc

joepeeples previously approved these changes May 27, 2025

View reviewed changes

temporal-github-worker-1 bot added the docs/approved label May 27, 2025

Merge branch 'master' into capmann-patch-2

71a1746

dd-devflow bot added the mergequeue-status: waiting label May 27, 2025

dd-devflow bot added mergequeue-status: removed and removed mergequeue-status: waiting labels May 27, 2025

dd-devflow bot added mergequeue-status: waiting and removed mergequeue-status: removed labels May 28, 2025

dd-devflow bot added mergequeue-status: removed and removed mergequeue-status: waiting labels May 28, 2025

iliakur previously approved these changes May 28, 2025

View reviewed changes

temporal-github-worker-1 bot added the agent/approved label May 28, 2025

steveny91 previously approved these changes May 28, 2025

View reviewed changes

dd-devflow bot added mergequeue-status: waiting mergequeue-status: removed and removed mergequeue-status: removed mergequeue-status: waiting labels May 29, 2025

scott-xue-datadog reviewed May 29, 2025

View reviewed changes

Update cmd_latency.json

018c124

temporal-github-worker-1 bot added agent/review-requested docs/review-requested and removed agent/approved docs/approved labels Jun 3, 2025

Update cmd_latency.json

a8ede09

Update manifest.json #20383

Are you sure you want to change the base?

Update manifest.json #20383

Uh oh!

Conversation

capmann commented May 27, 2025

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

Uh oh!

capmann commented May 27, 2025

Uh oh!

dd-devflow bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

capmann commented May 27, 2025

Uh oh!

dd-devflow bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

capmann commented May 28, 2025

Uh oh!

dd-devflow bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

capmann commented May 29, 2025

Uh oh!

dd-devflow bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dd-devflow bot commented May 27, 2025 •

edited

Loading

dd-devflow bot commented May 27, 2025 •

edited

Loading

dd-devflow bot commented May 28, 2025 •

edited

Loading

dd-devflow bot commented May 29, 2025 •

edited

Loading