[DBMON-5404] Add TagManager class to dbm base utils #20397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sethsamuel
approved these changes
May 28, 2025
lu-zhengda
approved these changes
May 29, 2025
steveny91
approved these changes
May 29, 2025
temporal-github-worker-1
bot
added
agent/approved
and removed
agent/review-requested
labels
domalessi
pushed a commit
that referenced
this pull request
May 29, 2025
* Add TagManager class to dbm utils * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new class TagManager to dbm's base utils module. This will be used to replace our current naive tag lists we maintain in the various dbms integrations. The goal of this class is to have an easy an efficient wrapper around tags that can allow us to efficiently perform CRUD type of operations on our list of tags in order to ensure that we can accurately modify tags over the life of the integration check as the source database values change and avoid emitting stale or inaccurate values.
Motivation
This is being added in order to fix an issue that affects all of our python dbms integrations. Having shared logic will allow us to ensure tagging logic is implemented the same across integrations
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged