Skip to content

Stop relying on manifest.json to validate spec.yaml #20398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 2, 2025

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented May 28, 2025

What does this PR do?

  1. Don't load manifest.json when validating the config and models we genreate from spec.yaml.
  2. Drop requirement for name field in spec.yaml. We don't use it anywhere.

! Update: I missed part of this and had to implement that in a follow-up PR!

Motivation

We're moving manifest.json to Publishing Platform, so we can't rely on it being present.
This is one step to reduce our dependency on it.
Without this change contributors using Publishing Platform will have failing validations.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (617cdb8) to head (1c211a9).
Report is 22 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
datadog_checks_dev 77.59% <100.00%> (-0.05%) ⬇️
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

steveny91
steveny91 previously approved these changes May 28, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed steveny91’s stale review May 29, 2025 15:37

Review from steveny91 is dismissed. Related teams and files:

  • agent-integrations
    • datadog_checks_dev/tests/tooling/configuration/test_load.py
@iliakur iliakur requested a review from steveny91 May 29, 2025 16:00
…e/models.py

Co-authored-by: NouemanKHAL <noueman.khalikine@datadoghq.com>
@iliakur iliakur enabled auto-merge June 2, 2025 12:18
@iliakur iliakur added this pull request to the merge queue Jun 2, 2025
Merged via the queue into master with commit baeffa3 Jun 2, 2025
24 checks passed
@iliakur iliakur deleted the ik/hardcode-spec-yaml-path branch June 2, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants