-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Stop relying on manifest.json to validate spec.yaml #20398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
steveny91
previously approved these changes
May 28, 2025
Review from steveny91 is dismissed. Related teams and files:
- agent-integrations
- datadog_checks_dev/tests/tooling/configuration/test_load.py
NouemanKHAL
reviewed
Jun 2, 2025
datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/models.py
Outdated
Show resolved
Hide resolved
…e/models.py Co-authored-by: NouemanKHAL <noueman.khalikine@datadoghq.com>
NouemanKHAL
reviewed
Jun 2, 2025
datadog_checks_dev/datadog_checks/dev/tooling/commands/validate/models.py
Outdated
Show resolved
Hide resolved
NouemanKHAL
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
manifest.json
when validating the config and models we genreate fromspec.yaml
.name
field inspec.yaml
. We don't use it anywhere.! Update: I missed part of this and had to implement that in a follow-up PR!
Motivation
We're moving
manifest.json
to Publishing Platform, so we can't rely on it being present.This is one step to reduce our dependency on it.
Without this change contributors using Publishing Platform will have failing validations.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged