Ex builtin archives #896
Open
Ex builtin archives #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, update examples_tests
…s_tests submodule
…e options, get rid of FXC entries for VS generators with VS_TOOL_OVERRIDE property, update examples_tests submodules. TODO: I need to make it more generic and allow to embed additional files next to precompiled SPIRV to share the same mount point
…RING_RESOLVER_TU_DEBUG_OPTIMISATION enabled by default and force threading=0 for wave - combined gives over 3x compilation boost in Debug and its almost perf-like RWDI now, update docker/compiler-explorer submodule
|
|
||
| namespace nbl::wave | ||
| { | ||
| std::string resolveString(std::string& code, const nbl::asset::IShaderCompiler::SPreprocessorOptions& preprocessOptions, bool withCaching, std::function<void(nbl::wave::context&)> post) |
There was a problem hiding this comment.
change the name from resolveString to just preprocess or preprocessString
| { | ||
| nbl::wave::context context(code.begin(), code.end(), preprocessOptions.sourceIdentifier.data(), { preprocessOptions }); | ||
| context.set_caching(withCaching); | ||
| context.add_macro_definition("__HLSL_VERSION"); |
There was a problem hiding this comment.
can you add defines for __SPIRV_MAJOR_VERSION__ and __SPIRV_MINOR_VERSION__
(requires moving of E_SPIRV_VERSION targetSpirvVersion = E_SPIRV_VERSION::ESV_1_6; from SCompilerOptions to SPreprocessorOptions)
…make it more general purpose, update examples_tests submodule
…, define `__SPIRV_MAJOR_VERSION__` and `__SPIRV_MINOR_VERSION__`, update examples_tests submodules
…e incremental updates for NSC rules and single step for registering archive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
TODO list: