Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump ring from 0.17.8 to 0.17.13 in the cargo group across 1 directory #1878

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 7, 2025

Bumps the cargo group with 1 update in the / directory: ring.

Updates ring from 0.17.8 to 0.17.13

Changelog

Sourced from ring's changelog.

Version 0.17.13 (2025-03-06)

Increased MSRV to 1.66.0 to avoid bugs in earlier versions so that we can safely use core::arch::x86_64::__cpuid and core::arch::x86::__cpuid from Rust in future releases.

AVX2-based VAES-CLMUL implementation. This will be a notable performance improvement for most newish x86-64 systems. This will likely raise the minimum binutils version supported for very old Linux distros.

Version 0.17.12 (2025-03-05)

Bug fix: briansmith/ring#2447 for denial of service (DoS).

  • Fixes a panic in ring::aead::quic::HeaderProtectionKey::new_mask() when integer overflow checking is enabled. In the QUIC protocol, an attacker can induce this panic by sending a specially-crafted packet. Even unintentionally it is likely to occur in 1 out of every 2**32 packets sent and/or received.

  • Fixes a panic on 64-bit targets in ring::aead::{AES_128_GCM, AES_256_GCM} when overflow checking is enabled, when encrypting/decrypting approximately 68,719,476,700 bytes (about 64 gigabytes) of data in a single chunk. Protocols like TLS and SSH are not affected by this because those protocols break large amounts of data into small chunks. Similarly, most applications will not attempt to encrypt/decrypt 64GB of data in one chunk.

Overflow checking is not enabled in release mode by default, but RUSTFLAGS="-C overflow-checks" or overflow-checks = true in the Cargo.toml profile can override this. Overflow checking is usually enabled by default in debug mode.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps the cargo group with 1 update in the / directory: [ring](https://github.com/briansmith/ring).


Updates `ring` from 0.17.8 to 0.17.13
- [Changelog](https://github.com/briansmith/ring/blob/main/RELEASES.md)
- [Commits](https://github.com/briansmith/ring/commits)

---
updated-dependencies:
- dependency-name: ring
  dependency-type: indirect
  dependency-group: cargo
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Mar 7, 2025
EliahKagan added a commit to EliahKagan/gitoxide that referenced this pull request Mar 8, 2025
https://rustsec.org/advisories/RUSTSEC-2024-0436.html now causes
the `cargo deny advisories` check to fail (even if the separate and
more important failure from `ring` is changed by bumping the `ring`
version, as in GitoxideLabs#1878).

`paste` is mature and would be hard to remove as a transitive
dependency at this time:

    > cargo tree --invert paste --no-dedupe --depth 3
    paste v1.0.15 (proc-macro)
    └── ratatui v0.26.3
        ├── crosstermion v0.14.0
        │   ├── gitoxide v0.41.0 (C:\Users\ek\source\repos\gitoxide)
        │   └── prodash v29.0.0
        ├── prodash v29.0.0
        │   ├── gitoxide v0.41.0 (C:\Users\ek\source\repos\gitoxide)
        │   ├── gix v0.70.0 (C:\Users\ek\source\repos\gitoxide\gix)
        │   └── gix-features v0.40.0 (C:\Users\ek\source\repos\gitoxide\gix-features)
        └── tui-react v0.23.2
            ├── crosstermion v0.14.0
            └── prodash v29.0.0

As discussed in rustsec/advisory-db#2215
and leptos-rs/leptos#3685, `paste` is
widely used and there is community interest in maintaining it.

When the status changes or more information about the future of
`paste` or its alternatives is available, `deny.toml` could be
updated again (even if only with a comment).
Copy link
Member

@EliahKagan EliahKagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This bumps ring to a version unaffected by RUSTSEC-2025-0009. The continued failure of cargo deny advisories even after this change is separate from this and due to RUSTSEC-2024-0436 in paste, for which I have opened #1879. The other failures are conceptually unrelated and also happening on main, see #1870 (#1849) and #1874.

EliahKagan added a commit to EliahKagan/gitoxide that referenced this pull request Mar 9, 2025
https://rustsec.org/advisories/RUSTSEC-2024-0436.html now causes
the `cargo deny advisories` check to fail (even if the separate and
more important failure from `ring` is fixed by bumping the `ring`
version, as in GitoxideLabs#1878).

`paste` is mature and would be hard to remove as a transitive
dependency at this time:

    > cargo tree --invert paste --no-dedupe --depth 3
    paste v1.0.15 (proc-macro)
    └── ratatui v0.26.3
        ├── crosstermion v0.14.0
        │   ├── gitoxide v0.41.0 (C:\Users\ek\source\repos\gitoxide)
        │   └── prodash v29.0.0
        ├── prodash v29.0.0
        │   ├── gitoxide v0.41.0 (C:\Users\ek\source\repos\gitoxide)
        │   ├── gix v0.70.0 (C:\Users\ek\source\repos\gitoxide\gix)
        │   └── gix-features v0.40.0 (C:\Users\ek\source\repos\gitoxide\gix-features)
        └── tui-react v0.23.2
            ├── crosstermion v0.14.0
            └── prodash v29.0.0

As discussed in rustsec/advisory-db#2215
and leptos-rs/leptos#3685, `paste` is
widely used and there is community interest in maintaining it.

When the status changes or more information about the future of
`paste` or its alternatives is available, `deny.toml` could be
updated again (even if only with a comment).
@EliahKagan
Copy link
Member

EliahKagan commented Mar 11, 2025

As suspected in #1879 (comment), I think 93fd329 (added in #1882) supersedes the changes here, such that this PR can be closed. I conclude this based on manual inspection of the versions, as well as an experiment with the analogous PR in my fork (EliahKagan#10) that Dependabot automatically detected was no longer needed, and that it closed, when I issued @dependabot rebase. But to be extra safe, you could if you like issue that command here to let Dependabot close it after verifying that.

@Byron
Copy link
Member

Byron commented Mar 11, 2025

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 11, 2025

Looks like ring is no longer updatable, so this is no longer needed.

@dependabot dependabot bot closed this Mar 11, 2025
@dependabot dependabot bot deleted the dependabot/cargo/cargo-134c95710a branch March 11, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants