Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gae): Remove older region tag #4018

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hivanalejandro
Copy link
Contributor

@hivanalejandro hivanalejandro commented Mar 6, 2025

Description

Fixes b/401222835

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@hivanalejandro hivanalejandro requested review from a team as code owners March 6, 2025 14:48
Copy link

snippet-bot bot commented Mar 6, 2025

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. asset: pattern DEE Asset tagging - Pattern. labels Mar 6, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hivanalejandro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request removes an older region tag ([START app_yaml] and [END app_yaml]) from the app.yaml file. The goal is to address the issue reported in b/401222835. The change simplifies the file by removing the now-unnecessary region tag, while retaining the relevant gae_app_yaml tags.

Highlights

  • Region Tag Removal: The pull request removes the older app_yaml region tag from the app.yaml file.
  • Issue Fix: This change addresses the issue reported in b/401222835.

Changelog

  • appengine/building-an-app/build/app.yaml
    • Removed the [START app_yaml] region tag.
    • Removed the [END app_yaml] region tag.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Did you know?

YAML is often used for configuration files because it is human-readable and easy to parse.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request removes an older region tag from the app.yaml file. The change seems straightforward and aims to clean up the configuration file. However, it's important to ensure that the removal of this tag doesn't impact any existing functionality or documentation that might be relying on it.

Summary of Findings

  • Region Tag Removal: The pull request removes the [START app_yaml] and [END app_yaml] region tags. It's important to verify that no other part of the codebase or documentation relies on these specific tags. If they are still in use, removing them could break functionality or cause confusion.

Merge Readiness

The pull request appears to be a simple cleanup task. However, before merging, it's crucial to confirm that the removed region tags are indeed obsolete and not used elsewhere in the project or documentation. I am unable to directly approve the pull request, and users should have others review and approve this code before merging. I recommend verifying the usage of the removed tags before merging.

Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're going to need to modify the page that is using app_yaml before you can remove this

@hivanalejandro hivanalejandro added the snippet-bot:force-run Force snippet-bot runs its logic label Mar 18, 2025
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Mar 18, 2025
@hivanalejandro hivanalejandro marked this pull request as draft March 20, 2025 14:55
@@ -11,8 +11,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# [START app_yaml]
Copy link
Contributor

@eapl-gemugami eapl-gemugami Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You are going to have a conflict with the rename in PR chore(gae): Remove older region tag #4032 for file appengine/building-an-app/update/app.yaml.

  2. The fixed region tag requires a language suffix for node

See polls.yaml#L25 as an example, and the internal resource naming-a-new-region-tag

~ ~ ~

You could use gae_build_app_yaml_node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: appengine Issues related to the App Engine Admin API API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants