-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DO NOT MERGE: experiment with forked repos #4027
base: main
Are you sure you want to change the base?
DO NOT MERGE: experiment with forked repos #4027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @davidcavazos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request, titled "DO NOT MERGE: experiment with forked repos," is purely for experimentation with tests from a forked repository. The only change involves adding a TODO
comment in tpu/test/tpu.test.js
to trigger tests.
Highlights
- Experimentation: This PR is created for experimenting with tests from a forked repo and should not be merged.
- Comment Addition: A
TODO
comment was added totpu/test/tpu.test.js
to trigger tests.
Changelog
- tpu/test/tpu.test.js
- Added a
TODO
comment to trigger tests.
- Added a
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The term 'fork' in software development is borrowed from the concept of a 'fork in the road,' where a path splits into two. In version control, forking creates a separate branch of development.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces a temporary comment to trigger tests. While this is acceptable for experimental purposes, it's important to ensure it's removed before merging into the main branch. I have provided feedback to address this.
Summary of Findings
- Temporary Comment: A temporary comment was added to trigger tests. This should be removed before merging.
Merge Readiness
The pull request is currently not ready for merging due to the presence of a temporary comment. This comment should be removed before merging. I am unable to directly approve the pull request, and other reviewers should review and approve this code before merging.
tpu/test/tpu.test.js
Outdated
// TODO: remove this comment, used to trigger tests only | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
DO NOT MERGE
This PR is only to experiment with tests from a forked repo.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.