Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: experiment with forked repos #4027

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

davidcavazos
Copy link
Contributor

Description

DO NOT MERGE

This PR is only to experiment with tests from a forked repo.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@davidcavazos davidcavazos added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 12, 2025
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 12, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @davidcavazos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request, titled "DO NOT MERGE: experiment with forked repos," is purely for experimentation with tests from a forked repository. The only change involves adding a TODO comment in tpu/test/tpu.test.js to trigger tests.

Highlights

  • Experimentation: This PR is created for experimenting with tests from a forked repo and should not be merged.
  • Comment Addition: A TODO comment was added to tpu/test/tpu.test.js to trigger tests.

Changelog

  • tpu/test/tpu.test.js
    • Added a TODO comment to trigger tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Did you know?

The term 'fork' in software development is borrowed from the concept of a 'fork in the road,' where a path splits into two. In version control, forking creates a separate branch of development.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a temporary comment to trigger tests. While this is acceptable for experimental purposes, it's important to ensure it's removed before merging into the main branch. I have provided feedback to address this.

Summary of Findings

  • Temporary Comment: A temporary comment was added to trigger tests. This should be removed before merging.

Merge Readiness

The pull request is currently not ready for merging due to the presence of a temporary comment. This comment should be removed before merging. I am unable to directly approve the pull request, and other reviewers should review and approve this code before merging.

Comment on lines 19 to 20
// TODO: remove this comment, used to trigger tests only

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This comment is intended to be temporary and should be removed once it has served its purpose. Leaving it in the code could lead to confusion or unintended behavior in the future. Please remove it before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant