-
Notifications
You must be signed in to change notification settings - Fork 136
fix(frontend): resolve dependencies vulnerabilities #1082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): resolve dependencies vulnerabilities #1082
Conversation
WalkthroughThe updates include dependency upgrades for both the frontend and widget projects, with major version bumps for Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant NextConfig
participant DevServer
Developer->>NextConfig: Updates devIndicators position
Developer->>DevServer: Runs dev script (now with --turbopack)
DevServer->>NextConfig: Loads updated config
DevServer->>Developer: Starts with new dev indicators and Turbopack
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (4)
frontend/next.config.mjs
(1 hunks)frontend/package.json
(3 hunks)frontend/tsconfig.json
(3 hunks)widget/package.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Frontend Tests
- GitHub Check: API-Tests
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (6)
frontend/next.config.mjs (1)
29-31
: Approve devIndicators configuration additionThe new
devIndicators
option correctly positions the Next.js development-mode indicator in the bottom-right corner and aligns with Next.js v15’s configuration schema. No further changes needed here.frontend/tsconfig.json (2)
4-8
: Approve multi-linelib
formattingReformatting the
lib
array into multiple lines improves readability and maintainability without altering behavior.
40-42
: Approve exclusion formattingConverting the
exclude
setting into a multi-line array is purely stylistic and maintains the same behavior.frontend/package.json (3)
9-9
: Approvedev
script updateEnabling Turbopack via
--turbopack
in the dev script leverages Next.js v15’s new bundler. This change is valid and enhances startup performance in development.
32-32
: Approveaxios
version bumpUpgrading
axios
to^1.8.1
addresses known vulnerabilities and introduces minor improvements.
56-62
: Approve devDependencies upgrades & verify compatibilityUpdating
@typescript-eslint/eslint-plugin
,eslint-import-resolver-typescript
, andtypescript
aligns with your upgraded toolchain.Please run your full lint and typecheck suite to ensure nothing is broken:
npm run lint
npm run typecheck
Motivation
The primary goal is to address vulnerabilities related to UI dependencies.
Fixes #754
Summary by CodeRabbit