Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enabling network auto masking #1314

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

feat: enabling network auto masking #1314

wants to merge 12 commits into from

Conversation

kholood-ea
Copy link
Contributor

Description of the change

Adding enable/disable network logs sensitive information auto masking feature

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JiraID: MOB-16551

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@kholood-ea kholood-ea self-assigned this Nov 13, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug self-requested a review November 26, 2024 13:33
ahmedAlaaInstabug
ahmedAlaaInstabug reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@ahmedAlaaInstabug ahmedAlaaInstabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job,, just there is a problem in pod install in ios jobs,, can you check it ?
@kholood-ea

a7medev
a7medev previously approved these changes Nov 27, 2024
View reviewed changes
@InstabugCI
Copy link
Collaborator

InstabugCI commented Nov 28, 2024 •
edited
Loading

Coverage Report

Label Coverage Status
JavaScript 95.6% ✅
Android 50.3% ✅
iOS 51.7% ✅

Generated by 🚫 dangerJS against 1e092cb

AyaMahmoud148
AyaMahmoud148 previously approved these changes Dec 1, 2024
View reviewed changes
@ahmedAlaaInstabug ahmedAlaaInstabug dismissed stale reviews from AyaMahmoud148 and themself via 040d817 December 22, 2024 11:58
@MoniraOsama MoniraOsama added the READY FOR MERGE Reviewed and ready for merge (after release request) label Jan 2, 2025
@a7medev a7medev removed their request for review March 11, 2025 12:38
AndrewAminInstabug
AndrewAminInstabug reviewed Mar 19, 2025
View reviewed changes
Copy link
Contributor

@AndrewAminInstabug AndrewAminInstabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kholood-ea Could you rebase the branch onto the dev branch and resolve the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewAminInstabug AndrewAminInstabug

@a7medev a7medev

@ahmedAlaaInstabug ahmedAlaaInstabug

@AyaMahmoud148 AyaMahmoud148

At least 2 approving reviews are required to merge this pull request.

Assignees

@kholood-ea kholood-ea

Labels
READY FOR MERGE Reviewed and ready for merge (after release request)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kholood-ea @InstabugCI @a7medev @ahmedAlaaInstabug @AndrewAminInstabug @AyaMahmoud148 @MoniraOsama