Skip to content

Commit ce562be

Browse files
committed
Restore Python 3.5 support
Fixes: #48
1 parent d4aa97b commit ce562be

File tree

3 files changed

+17
-6
lines changed

3 files changed

+17
-6
lines changed

.github/workflows/release.yml

+7-1
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,14 @@ jobs:
7070
runs-on: ${{ matrix.os }}
7171
strategy:
7272
matrix:
73-
python-version: [3.6, 3.7, 3.8]
73+
python-version: [3.5, 3.6, 3.7, 3.8]
7474
os: [ubuntu-16.04, macos-latest, windows-latest]
75+
exclude:
76+
# Python 3.5 is unable to properly
77+
# find the recent VS tooling
78+
# https://bugs.python.org/issue30389
79+
- os: windows-latest
80+
python-version: 3.5
7581

7682
steps:
7783
- uses: actions/checkout@v1

.github/workflows/tests.yml

+7-1
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,14 @@ jobs:
1515
strategy:
1616
max-parallel: 4
1717
matrix:
18-
python-version: [3.6, 3.7, 3.8]
18+
python-version: [3.5, 3.6, 3.7, 3.8]
1919
os: [windows-latest, ubuntu-18.04, macos-latest]
20+
exclude:
21+
# Python 3.5 is unable to properly
22+
# find the recent VS tooling
23+
# https://bugs.python.org/issue30389
24+
- os: windows-latest
25+
python-version: 3.5
2026

2127
steps:
2228
- uses: actions/checkout@v1

setup.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -116,19 +116,18 @@ def build_extensions(self):
116116
# Support macports on Mac OS X.
117117
self.compiler.add_include_dir('/opt/local/include')
118118
else:
119-
self.compiler.add_include_dir(
120-
os.path.join(ROOT, 'vendor/http-parser'))
119+
self.compiler.add_include_dir(str(ROOT / 'vendor' / 'http-parser'))
121120
self.distribution.ext_modules[0].sources.append(
122121
'vendor/http-parser/http_parser.c')
123122

124123
super().build_extensions()
125124

126125

127-
with open(os.path.join(ROOT, 'README.md')) as f:
126+
with open(str(ROOT / 'README.md')) as f:
128127
long_description = f.read()
129128

130129

131-
with open(os.path.join(ROOT, 'httptools', '_version.py')) as f:
130+
with open(str(ROOT / 'httptools' / '_version.py')) as f:
132131
for line in f:
133132
if line.startswith('__version__ ='):
134133
_, _, version = line.partition('=')

0 commit comments

Comments
 (0)