Skip to content

detach attacker on transformation #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

drbergman
Copy link
Collaborator

  • the attack already (in 1.14.0) ends when the attacker transforms
  • do not let the spring attachment persist after the transform as well

- the attack already ends when the attacker transforms
- do not let the spring attachment persist after the transform as well
@drbergman
Copy link
Collaborator Author

drbergman commented Dec 2, 2024

Here's an example demonstrating the need. The attacker (grey cell) attacks the defender (red cell). The attacker transforms into an exhausted cell (yellow cell). Meanwhile, the defender is chemotaxing to the left and the spring attachment between the two persists even after the attack has ceased. I have also included the config and cells.csv to recreate from the template project.

https://github.com/user-attachments/assets/1ca37563-35df-4959-8374-b652a27bf8b4
PhysiCell_settings.txt
cells.csv

@heberlr heberlr mentioned this pull request Dec 5, 2024
@MathCancer MathCancer deleted the branch MathCancer:development December 13, 2024 23:02
@MathCancer MathCancer closed this Dec 13, 2024
@heberlr heberlr reopened this Dec 20, 2024
@drbergman drbergman marked this pull request as ready for review April 4, 2025 15:06
@drbergman drbergman requested a review from Copilot April 4, 2025 15:07
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

core/PhysiCell_cell.cpp:1134

  • [nitpick] Consider using 'nullptr' instead of 'NULL' to align with modern C++ practices.
if ( phenotype.cell_interactions.pAttackTarget != NULL )

@drbergman drbergman self-assigned this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants