Skip to content

msys2 package list clean out and brew gcc update to v14. #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

elmbeech
Copy link
Contributor

@elmbeech elmbeech commented Feb 3, 2025

lately i was writing new physicell installation manuals for the power users.
thereby, i cleaned out the msys2 package list.
additionally, i noticed that brew nowadays ships with gcc version 14.
this is an update to the workflow files from what i learned on the way.

@drbergman drbergman requested review from Copilot and drbergman May 22, 2025 13:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up the msys2 package list for Windows CI jobs and upgrades the macOS compiler in both test and binary‐build workflows from GCC 13 to GCC 14.

  • Remove many legacy msys2 packages and streamline installed dependencies.
  • Update GitHub Actions matrices to use g++-14 on macOS.
  • Change Homebrew logic to install and reference gcc@14 instead of gcc@13.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/tests.yml Reduced msys2 install list; bumped macOS compiler entries to g++-14.
.github/workflows/build_binaries.yml Adjusted msys2 dependencies; updated Homebrew GCC install and build commands to gcc@14.
Comments suppressed due to low confidence (3)

.github/workflows/tests.yml:55

  • By removing packages like lapack, openblas, pthread and Python bindings, the Windows build or tests may now fail if those libraries are actually required. Please confirm which dependencies are still needed and restore any that are missing.
install: mingw-w64-x86_64-gcc make mingw-w64-x86_64-imagemagick mingw-w64-x86_64-ffmpeg unzip zip git mingw-w64-x86_64-ca-certificates mingw-w64-x86_64-diffutils

.github/workflows/build_binaries.yml:85

  • Similar to the tests workflow, critical MSYS2 packages (e.g., libwinpthread, lapack, openblas, Python CFFI) were removed and might be required for a successful Windows binary build. Double-check and re-add missing dependencies.
install: mingw-w64-x86_64-gcc make mingw-w64-x86_64-imagemagick mingw-w64-x86_64-ffmpeg unzip zip git mingw-w64-x86_64-python-zstandard mingw-w64-x86_64-ca-certificates

.github/workflows/build_binaries.yml:137

  • [nitpick] After installing gcc@14, consider exporting its bin directory (e.g., export PATH="$(brew --prefix gcc@14)/bin:$PATH") so that g++-14 is reliably found on all macOS runners.
if ! brew list gcc@14 &>/dev/null; then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant