Skip to content

when asym divs probs sum to >1, exit with msg #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

drbergman
Copy link
Collaborator

@heberlr first identified this behavior and a discussion led to opening #347. While better handling of thrown exceptions would be an improvement, for now have this error behave like all others and exit(-1).

previously, used throw but the standard main.cpp catches the exception and still exits with 0

previously, used `throw` but the standard `main.cpp` catches the exception and still exits with 0
@drbergman drbergman requested a review from Copilot April 4, 2025 15:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

core/PhysiCell_standard_models.cpp:1385

  • The use of 'pCD_parent' appears to be incorrect as the function parameters use 'pCell_parent'. This likely introduces a bug if 'pCD_parent' is not properly defined.
std::cerr << "Error: Asymmetric division probabilities for " + pCD_parent->name + " sum to greater than 1.0 and cannot be normalized." << std::endl;

@drbergman drbergman self-assigned this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant