update news; clean up sf-mapbox-data demo

Author: cpsievert

NEWS.md

@@ -4,15 +4,16 @@
 
 * Upgraded to plotly.js v1.35.2. A _huge_ amount of features and improvements have been made since v1.29.2 (i.e., the version included in the last CRAN release of the R package - v4.7.1). Highlights include a complete re-write of `scattergl` to make it nearly feature complete with `scatter`, localization of text rendering (i.e., international translations), and two new trace types (`violin` & `table`). Read more about the v1.32.0 release [here](https://codeburst.io/notes-from-the-latest-plotly-js-release-b035a5b43e21) and the complete list of changes [here](https://github.com/plotly/plotly.js/releases).
 * Support for **sf** (simple feature) data structures was added to `plot_ly()`, `plot_mapbox()`, and `plot_geo()` (via the new `add_sf()` function). See [this blog post](https://blog.cpsievert.me/2018/03/30/visualizing-geo-spatial-data-with-sf-and-plotly) for an overview.
-* New "special arguments" `stroke`, `strokes`, `alpha_stroke`, `span`, and `spans` were added for easier control over the stroke (i.e., outline) appearance of various (filled) graphical marks. For an overview, see the **sf** blog post linked to in the bullet point above.
+* New "special arguments" `stroke`, `strokes`, `alpha_stroke`, `span`, and `spans` were added for easier control over the stroke (i.e., outline) appearance of various (filled) graphical marks. For an overview, see the **sf** blog post linked to in the bullet point above and the new package demos (list all demos with `demo(package = "plotly")`).
 * The selection (i.e., linked-brushing) mode can now switch from 'transient' to 'persistent' by holding the 'shift' key. It's still possible to _force_ persistent selection by setting `persistent = TRUE` in `highlight()`, but `persistent = FALSE` (the default) is now recommended since it allows one to switch between [persistent/transient selection](https://plotly-book.cpsievert.me/linking-views-without-shiny.html#transient-versus-persistent-selection) in the browser, rather than at the command line.
 * Instead of an error, `ggplotly(NULL, "message")` and `plotly_build(NULL, "message")` now returns `htmltools::div("message")`, making it easier to relay messages in shiny when data isn't yet ready to plot (see #1116)
 * The `animation_button()` function gains a `label` argument, making it easier to control the label of an animation button generated through the `frame` API (see #1205).
 
 ## CHANGES
 
 * The `color` argument now maps to `fillcolor`, making it much easier to use polygon fills to encode data values (e.g., choropleth maps). For backwards-compatibilty reasons, when `color` maps to `fillcolor`, `alpha` defaults to 0.5 (instead of 1). For an example, `plot_mapbox(mn_res, color = ~INDRESNAME)` or `plot_mapbox(mn_res, split = ~INDRESNAME, color = ~AREA, showlegend = FALSE, stroke = I("black"))`.
-* The `color` argument no longer automatically add `"markers"` to the `mode` attribute for scatter/scattergl trace types. Those who wish to have the old behavior back, should add `"markers"` to the `mode` explicity (e.g., change `plot_ly(economics, x = ~pce, y = ~pop, color = ~as.numeric(date), mode = "lines")` to `plot_ly(economics, x = ~pce, y = ~pop, color = ~as.numeric(date), mode = "lines+markers")`)
+* The `color` argument no longer automatically add `"markers"` to the `mode` attribute for scatter/scattergl trace types. Those who wish to have the old behavior back, should add `"markers"` to the `mode` explicity (e.g., change `plot_ly(economics, x = ~pce, y = ~pop, color = ~as.numeric(date), mode = "lines")` to `plot_ly(economics, x = ~pce, y = ~pop, color = ~as.numeric(date), mode = "lines+markers")`).
+* `layout.showlegend` now defaults to `TRUE` for a *single* pie trace. This is a more sensible default and matches pure plotly.js behavior.
 * The `elementId` field is no longer populated, which fixes the "Ignoring explicitly provided widget ID" warning in shiny applications (see #985).
 
 ## BUG FIXES

demo/sf-mapbox-data.R

@@ -1,48 +1,35 @@
-library(sf)
-
-plot_mapbox(res_mn)
-plot_mapbox(res_mn, split = ~INDRESNAME)
-
-
-library(sf)
 library(plotly)
+library(crosstalk)
 
-nc <- st_read(system.file("shape/nc.shp", package = "sf"), quiet = TRUE)
-
-# can set multiple bounding boxes and overwrite attributes 
-subplot(
-  plot_mapbox(nc),
-  plot_mapbox(nc, fillcolor = "gray", line = list(size = 0.01, color = "black"))
+# one trace
+plot_mapbox(res_mn)
+plot_mapbox(res_mn, stroke = I("#119dff"), span = I(1), color = I("#00cc96"))
+
+# multiple traces 
+plot_mapbox(res_mn, split = ~INDRESNAME, span = I(1))
+plot_mapbox(res_mn, split = ~INDRESNAME, color = ~AREA, stroke = ~PERIMETER, span = I(1))
+
+# linking with DT
+mn <- crosstalk::SharedData$new(res_mn)
+bscols(
+  plot_mapbox(mn, split = ~INDRESNAME, text = ~INDRESNAME, hoverinfo = "text", hoveron = "fill") %>%
+    layout(title = "Click a reservation", showlegend = FALSE),
+  DT::datatable(mn)
 )
 
-# map custom hover text to each point
-# (unfortunately, scattermapbox does not yet support hoveron='fill')
-plot_mapbox(nc, text = ~paste0(NAME, ": ", AREA), hoverinfo = "text")
-
-
-col_scale <- scales::col_numeric("Blues", range(nc$AREA))
-plot_ly(nc, fillcolor = ~col_scale(AREA), text = ~AREA, hoveron = "fill") %>%
-  layout(showlegend = FALSE)
-
-# TODO: animation
+nc <- sf::st_read(system.file("shape/nc.shp", package = "sf"), quiet = TRUE)
+ncsd <- SharedData$new(nc)
 
 
-# TODO: click to highlight
-ncsd <- crosstalk::SharedData$new(nc)
-plot_mapbox(ncsd)
-
-
-# TODO: perhaps during verification, if hoveron = 'fill' for a given trace,
-# we could check if text is unique or not...if it is, just take first element
-plot_mapbox(nc, split = ~AREA, text = ~NAME, hoveron = "fill")
-
-# TODO: how to best control hoverinfo?
-
-
-
-# non-standard crs
-library(mapview)
-plot_mapbox(trails)
-
+# note that brushing counties is currently possible with plot_ly(), but isn't quite working 
+# yet with plot_mapbox() -- https://github.com/plotly/plotly.js/issues/2512
+bscols(
+  plot_mapbox(ncsd) %>%
+    highlight(dynamic = TRUE, persistent = TRUE),
+  plot_ly(ncsd, x = ~AREA) %>% 
+    add_histogram(xbins = list(start = 0, end = 0.3, size = 0.02)) %>%
+    layout(barmode = "overlay") %>% 
+    highlight("plotly_selected", persistent = TRUE)
+)
 
 

tests/testthat/test-plotly-sf.R

@@ -317,3 +317,22 @@ test_that("altogether now", {
 })
 
 
+
+test_that("color and stroke scales can be set independently", {
+  
+  n <- length(unique(res_mn$INDRESNAME))
+  p <- plot_mapbox(res_mn, split = ~INDRESNAME, color = ~AREA, stroke = ~PERIMETER, span = I(2)) %>%
+    plotly_build()
+  
+  # two colorbars
+  d <- p$x$data
+  expect_true(length(d) == n + 2)
+  
+  colorbars <- d[vapply(d, is.colorbar, logical(1))]
+  
+  expect_true(colorbars[[1]]$marker$colorbar$title == "AREA")
+  expect_true(colorbars[[2]]$marker$colorbar$title == "PERIMETER")
+  expect_true(all(colorbars[[1]]$marker$color == range(res_mn$AREA)))
+  expect_true(all(colorbars[[2]]$marker$color == range(res_mn$PERIMETER)))
+  
+})