Skip to content

Commit b5e749e

Browse files
cvinayakppryga-nordic
authored andcommitted
Bluetooth: Controller: Apply suggestions from code review
Apply suggestions from code review. Co-authored-by: Piotr Pryga <piotr.pryga@nordicsemi.no> Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
1 parent af5e6a1 commit b5e749e

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

subsys/bluetooth/controller/ll_sw/nordic/lll/lll_conn.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -723,6 +723,11 @@ void lll_conn_pdu_tx_prep(struct lll_conn *lll, struct pdu_data **pdu_data_tx)
723723
p->ll_id = PDU_DATA_LLID_DATA_CONTINUE;
724724

725725
#if defined(CONFIG_BT_CTLR_DF_CONN_CTE_TX)
726+
/* BT 5.3 Core Spec does not define handling of CP bit
727+
* for PDUs fragmented by Controller, hence the CP bit
728+
* is set to zero. The CTE should not be transmitted
729+
* with CONTINUE PDUs if fragmentation is performed.
730+
*/
726731
p->cp = 0U;
727732
p->resv = 0U;
728733
#endif /* CONFIG_BT_CTLR_DF_CONN_CTE_TX */
@@ -1002,6 +1007,11 @@ static void empty_tx_init(void)
10021007

10031008
p = (void *)radio_pkt_empty_get();
10041009
p->ll_id = PDU_DATA_LLID_DATA_CONTINUE;
1010+
1011+
/* cp, rfu, and resv fields in the empty PDU buffer is statically
1012+
* zero initialized at power up and these values in this buffer are
1013+
* not modified at runtime.
1014+
*/
10051015
}
10061016

10071017
#if defined(CONFIG_BT_CTRL_DF_CONN_CTE_RX)

subsys/bluetooth/controller/ll_sw/ull_conn.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2052,8 +2052,6 @@ uint16_t ull_conn_lll_max_tx_octets_get(struct lll_conn *lll)
20522052

20532053
/**
20542054
* @brief Initialize pdu_data members that are read only in lower link layer.
2055-
* Fields that are modified after static initialization are only
2056-
* re-initialized.
20572055
*
20582056
* @param pdu_tx Pointer to pdu_data object to be initialized
20592057
*/

0 commit comments

Comments
 (0)