Skip to content

Modify the wording to avoid misreading #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2020
Merged

Modify the wording to avoid misreading #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e72238b
Modify the wording to avoid misreading
EightMinuteYouth Mar 31, 2020
bfba886
Modify the wording to avoid misreading
EightMinuteYouth Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions mecury_project/example/provider_example/lib/screens.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import 'package:flutter/material.dart';
import 'package:provider/provider.dart';
import 'package:provider_example/order_provider.dart';
import 'counter_model.dart';

import 'color_model.dart';
import 'counter_model.dart';
import 'goods_model.dart';

class FirstScreen extends StatelessWidget {
Expand All @@ -26,8 +27,7 @@ class FirstScreen extends StatelessWidget {
),
),
floatingActionButton: FloatingActionButton(
onPressed: () => Navigator.of(context)
.push(MaterialPageRoute(builder: (context) => SecondScreen())),
onPressed: () => Navigator.of(context).push(MaterialPageRoute(builder: (context) => SecondScreen())),
child: Icon(Icons.navigate_next),
),
);
Expand Down Expand Up @@ -95,8 +95,7 @@ class SecondScreen extends StatelessWidget {
),
SizedBox(height: 20),
Consumer<CounterModel>(
builder: (context, CounterModel counter, child) =>
FloatingActionButton(
builder: (context, CounterModel counter, child) => FloatingActionButton(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是 dartfmt 了吗

onPressed: () => counter.increment(),
child: child,
),
Expand Down Expand Up @@ -171,8 +170,7 @@ class GoodsListScreen extends StatelessWidget {
title: Text(data.goodsName),
trailing: GestureDetector(
onTap: () => provider.collect(index),
child: Icon(
data.isCollection ? Icons.star : Icons.star_border),
child: Icon(data.isCollection ? Icons.star : Icons.star_border),
),
);
},
Expand All @@ -196,7 +194,6 @@ class GoodsListScreen extends StatelessWidget {
}
}


class OrderListScreen extends StatefulWidget {
@override
_OrderListScreenState createState() => _OrderListScreenState();
Expand All @@ -211,22 +208,21 @@ class _OrderListScreenState extends State<OrderListScreen> {
value: _provider,
child: Scaffold(
body: Selector<OrderProvider, List<Order>>(
selector: (context, provider) => provider.orderList,
builder: (context, provider, child) {
selector: (BuildContext _, OrderProvider provider) => provider.orderList,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接 _

builder: (BuildContext _, List<Order> orderList, Widget __) {
return ListView.builder(
itemCount: _provider.listSize,
itemBuilder: (context, index) {
return Selector<OrderProvider, Order>(
selector: (context, provider) => provider.orderList[index],
builder: (context, data, child) {
selector: (BuildContext _, OrderProvider provider) => provider.orderList[index],
builder: (BuildContext _, Order data, Widget __) {
print(('No.${index + 1} rebuild'));

return ListTile(
title: Text(data.goodsName),
trailing: GestureDetector(
onTap: () => _provider.collect(index),
child: Icon(
data.isCollection ? Icons.star : Icons.star_border),
child: Icon(data.isCollection ? Icons.star : Icons.star_border),
),
);
},
Expand All @@ -236,7 +232,7 @@ class _OrderListScreenState extends State<OrderListScreen> {
},
),
floatingActionButton: Consumer<OrderProvider>(
builder: (context, OrderProvider provider, child) {
builder: (BuildContext _, OrderProvider provider, Widget __) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不传的话还是直接 _ 就好

return FloatingActionButton(
child: Icon(Icons.add),
onPressed: () {
Expand Down