Skip to content

Add noble32vcpkg #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add noble32vcpkg #16

wants to merge 1 commit into from

Conversation

duncanspumpkin
Copy link
Contributor

This adds a new dockfile that has only the required components for a vcpkg build for OpenLoco/OpenLoco#3010

Copy link

@tyrone-sudeium tyrone-sudeium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From OpenLoco/OpenLoco#3010 I had a couple of notes:

  • Tested a linux-vcpkg-static build on this image and unfortauntely it does not work. Seems like vcpkg alsa now also needs automake as well.
  • This image is based on noble but I probably would've gone with jammy. These static binaries still dynamically link with libc and friends so it's generally best to build on the oldest distro (and thus glibc) that is supported by the project, to ensure widest compatibility. Note that I haven't actually tested if there's any meaningful difference or breaking changes specifically between glibc 2.35 (jammy) and glibc 2.39 (noble) so it's possible this is a moot point

@AaronVanGeffen
Copy link
Member

With Ubuntu 25.04 out, I wonder if we should introduce a 25.04 image rather than duplicating the 24.04 one. That would extend test coverage instead, right?

@duncanspumpkin
Copy link
Contributor Author

With Ubuntu 25.04 out, I wonder if we should introduce a 25.04 image rather than duplicating the 24.04 one. That would extend test coverage instead, right?

The 24.04 image is an LTS release (5 years) image where as the 25.04 will just be an interim release (9 months). I'm fine with changing it to 25.04 but we will need to change it again in ~6months if we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants