Skip to content

Smart default value of DamageAlliesMultiplier and DamageOwnerMultiplier #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TaranDahl
Copy link
Contributor

@TaranDahl TaranDahl commented Jul 8, 2025

  • Warheads are now able to define the extra damage multiplier for owner house, ally houses and enemy houses.
    • DamageOwnerMultiplier.NotAffectsEnemies and DamageAlliesMultiplier.NotAffectsEnemies is used as the default value if AffectsEnemies=false is set on the warhead.

@TaranDahl TaranDahl requested a review from CrimRecya July 8, 2025 08:13
@TaranDahl TaranDahl added the Minor Documentation is not required label Jul 8, 2025
Copy link

github-actions bot commented Jul 8, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Coronia
Copy link
Contributor

Coronia commented Jul 8, 2025

I get what you want to do here, but the name SmartDefault is neither clear by itself nor able to suggest its usage. But for now I couldn't think of a better naming or tag style yet, would appreciate some suggestion @Metadorius

@TaranDahl
Copy link
Contributor Author

What about DamageMultiplierByHouse.IgnoreNotAffectsEnemies
Maybe clearer, but ... too long.

@TaranDahl
Copy link
Contributor Author

Master Doubao says DamageMultiplierByHouse.AdaptiveDefault

@Coronia
Copy link
Contributor

Coronia commented Jul 10, 2025

how about this, instead of a boolean toggle, we can make it into floating point values that would be used when 1) AffectsEnemies=false and 2) these values are set, otherwise it'll still follow the original tags

DamageAlliesMultiplier.NotAffectsEnemies=
DamageOwnerMultiplier.NotAffectsEnemies=

@CrimRecya
Copy link
Contributor

Both the PR description and the doc have been forgotten.

@TaranDahl TaranDahl merged commit ccbf850 into Phobos-developers:develop Jul 12, 2025
6 checks passed
@TaranDahl TaranDahl deleted the DamageMultiplierDefaultValue branch July 12, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Documentation is not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants