-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connect-react dev ex improvements #15672
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThe pull request adds a new script to the Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant CLI as Command Line
participant Vite as Vite Build Process
Dev->>CLI: Run "npm run watch"
CLI->>CLI: Set NODE_ENV=development
CLI->>Vite: Start Vite build (--watch, --mode development)
Vite->>CLI: Watch for file changes and trigger rebuilds
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/connect-react/package.json (1)
21-22
: Enhanced Development Experience with New Watch ScriptThe addition of the
"watch": "NODE_ENV=development vite build --watch --mode development"
script enables continuous rebuilding in development mode, which aligns well with the PR objectives. One suggestion is to consider cross-platform compatibility—particularly on Windows—by leveraging a tool likecross-env
to set environment variables reliably across different operating systems.For example, if Windows support is required, you could update the script as follows:
- "watch": "NODE_ENV=development vite build --watch --mode development" + "watch": "cross-env NODE_ENV=development vite build --watch --mode development"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/connect-react/package.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
WHY
Summary by CodeRabbit