-
Notifications
You must be signed in to change notification settings - Fork 45
Hue and Saturation adjustment augmentations on HOST and HIP #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r-abishek
commented
Jun 25, 2025
- Add Hue and Saturation adjustment augmentations on HOST and HIP for U8/F16/F32/I8 with NCHW/NHWC layout toggle variants
- Modify color_twist to use low level helper functions rgb_to_hsv() and hsv_to_rgb()
- Add relevant unit/QA/perf tests
RPP Hue and Saturation Tensor support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for hue and saturation adjustments across HOST and HIP backends, refactors color_twist to use dedicated RGB↔HSV helpers, and integrates new augmentations into the test suite.
- Extend augmentation mappings and enums for hue (42) and saturation (43)
- Implement host and GPU entry points and kernels for hue and saturation
- Refactor
color_twist
kernels to leveragergb_to_hsv
/hsv_to_rgb
helpers
Reviewed Changes
Copilot reviewed 16 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
utilities/test_suite/rpp_test_suite_image.h | Register HUE and SATURATION in the augmentation enum and map |
utilities/test_suite/common.py | Add hue/saturation entries to test parameters (typo notice) |
utilities/test_suite/HOST/Tensor_image_host.cpp | Add HOST test cases for HUE and SATURATION |
utilities/test_suite/HIP/Tensor_image_hip.cpp | Add HIP test cases and memory handling for HUE and SATURATION |
src/modules/tensor/rppt_tensor_color_augmentations.cpp | Add rppt_hue_* and rppt_saturation_* host/gpu entry points |
src/modules/tensor/hip/kernel/hue.cpp | Implement HIP kernels for hue adjustment |
src/modules/tensor/hip/kernel/saturation.cpp | Implement HIP kernels for saturation adjustment |
src/modules/tensor/hip/kernel/color_twist.cpp | Refactor color_twist to use rgb_to_hsv /hsv_to_rgb |
Comments suppressed due to low confidence (1)
utilities/test_suite/common.py:132
- Ensure that unit or QA tests explicitly cover the newly added hue (42) and saturation (43) augmentations so their registration and behavior are validated.
"color_augmentations" : [0, 1, 2, 3, 4, 13, 31, 34, 36, 42, 43, 45, 81],
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #573 +/- ##
===========================================
+ Coverage 87.54% 88.02% +0.48%
===========================================
Files 185 190 +5
Lines 78708 80802 +2094
===========================================
+ Hits 68898 71120 +2222
+ Misses 9810 9682 -128
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address review comments
RPP Hue and Sat : Address PR review comments