Skip to content

Commit 5b9fedb

Browse files
jankarajankara
committed
quota: Disable quotactl_path syscall
In commit fa8b900 ("quota: wire up quotactl_path") we have wired up new quotactl_path syscall. However some people in LWN discussion have objected that the path based syscall is missing dirfd and flags argument which is mostly standard for contemporary path based syscalls. Indeed they have a point and after a discussion with Christian Brauner and Sascha Hauer I've decided to disable the syscall for now and update its API. Since there is no userspace currently using that syscall and it hasn't been released in any major release, we should be fine. CC: Christian Brauner <christian.brauner@ubuntu.com> CC: Sascha Hauer <s.hauer@pengutronix.de> Link: https://lore.kernel.org/lkml/20210512153621.n5u43jsytbik4yze@wittgenstein Signed-off-by: Jan Kara <jack@suse.cz>
1 parent 8c721cb commit 5b9fedb

File tree

17 files changed

+17
-18
lines changed

17 files changed

+17
-18
lines changed

‎arch/alpha/kernel/syscalls/syscall.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@
482482
550 common process_madvise sys_process_madvise
483483
551 common epoll_pwait2 sys_epoll_pwait2
484484
552 common mount_setattr sys_mount_setattr
485-
553 common quotactl_path sys_quotactl_path
485+
# 553 reserved for quotactl_path
486486
554 common landlock_create_ruleset sys_landlock_create_ruleset
487487
555 common landlock_add_rule sys_landlock_add_rule
488488
556 common landlock_restrict_self sys_landlock_restrict_self

‎arch/arm/tools/syscall.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@
456456
440 common process_madvise sys_process_madvise
457457
441 common epoll_pwait2 sys_epoll_pwait2
458458
442 common mount_setattr sys_mount_setattr
459-
443 common quotactl_path sys_quotactl_path
459+
# 443 reserved for quotactl_path
460460
444 common landlock_create_ruleset sys_landlock_create_ruleset
461461
445 common landlock_add_rule sys_landlock_add_rule
462462
446 common landlock_restrict_self sys_landlock_restrict_self

‎arch/arm64/include/asm/unistd32.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -893,8 +893,7 @@ __SYSCALL(__NR_process_madvise, sys_process_madvise)
893893
__SYSCALL(__NR_epoll_pwait2, compat_sys_epoll_pwait2)
894894
#define __NR_mount_setattr 442
895895
__SYSCALL(__NR_mount_setattr, sys_mount_setattr)
896-
#define __NR_quotactl_path 443
897-
__SYSCALL(__NR_quotactl_path, sys_quotactl_path)
896+
/* 443 is reserved for quotactl_path */
898897
#define __NR_landlock_create_ruleset 444
899898
__SYSCALL(__NR_landlock_create_ruleset, sys_landlock_create_ruleset)
900899
#define __NR_landlock_add_rule 445

‎arch/ia64/kernel/syscalls/syscall.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@
363363
440 common process_madvise sys_process_madvise
364364
441 common epoll_pwait2 sys_epoll_pwait2
365365
442 common mount_setattr sys_mount_setattr
366-
443 common quotactl_path sys_quotactl_path
366+
# 443 reserved for quotactl_path
367367
444 common landlock_create_ruleset sys_landlock_create_ruleset
368368
445 common landlock_add_rule sys_landlock_add_rule
369369
446 common landlock_restrict_self sys_landlock_restrict_self

‎arch/m68k/kernel/syscalls/syscall.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@
442442
440 common process_madvise sys_process_madvise
443443
441 common epoll_pwait2 sys_epoll_pwait2
444444
442 common mount_setattr sys_mount_setattr
445-
443 common quotactl_path sys_quotactl_path
445+
# 443 reserved for quotactl_path
446446
444 common landlock_create_ruleset sys_landlock_create_ruleset
447447
445 common landlock_add_rule sys_landlock_add_rule
448448
446 common landlock_restrict_self sys_landlock_restrict_self

‎arch/microblaze/kernel/syscalls/syscall.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,7 @@
448448
440 common process_madvise sys_process_madvise
449449
441 common epoll_pwait2 sys_epoll_pwait2
450450
442 common mount_setattr sys_mount_setattr
451-
443 common quotactl_path sys_quotactl_path
451+
# 443 reserved for quotactl_path
452452
444 common landlock_create_ruleset sys_landlock_create_ruleset
453453
445 common landlock_add_rule sys_landlock_add_rule
454454
446 common landlock_restrict_self sys_landlock_restrict_self

‎arch/mips/kernel/syscalls/syscall_n32.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@
381381
440 n32 process_madvise sys_process_madvise
382382
441 n32 epoll_pwait2 compat_sys_epoll_pwait2
383383
442 n32 mount_setattr sys_mount_setattr
384-
443 n32 quotactl_path sys_quotactl_path
384+
# 443 reserved for quotactl_path
385385
444 n32 landlock_create_ruleset sys_landlock_create_ruleset
386386
445 n32 landlock_add_rule sys_landlock_add_rule
387387
446 n32 landlock_restrict_self sys_landlock_restrict_self

‎arch/mips/kernel/syscalls/syscall_n64.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@
357357
440 n64 process_madvise sys_process_madvise
358358
441 n64 epoll_pwait2 sys_epoll_pwait2
359359
442 n64 mount_setattr sys_mount_setattr
360-
443 n64 quotactl_path sys_quotactl_path
360+
# 443 reserved for quotactl_path
361361
444 n64 landlock_create_ruleset sys_landlock_create_ruleset
362362
445 n64 landlock_add_rule sys_landlock_add_rule
363363
446 n64 landlock_restrict_self sys_landlock_restrict_self

‎arch/mips/kernel/syscalls/syscall_o32.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -430,7 +430,7 @@
430430
440 o32 process_madvise sys_process_madvise
431431
441 o32 epoll_pwait2 sys_epoll_pwait2 compat_sys_epoll_pwait2
432432
442 o32 mount_setattr sys_mount_setattr
433-
443 o32 quotactl_path sys_quotactl_path
433+
# 443 reserved for quotactl_path
434434
444 o32 landlock_create_ruleset sys_landlock_create_ruleset
435435
445 o32 landlock_add_rule sys_landlock_add_rule
436436
446 o32 landlock_restrict_self sys_landlock_restrict_self

‎arch/parisc/kernel/syscalls/syscall.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@
440440
440 common process_madvise sys_process_madvise
441441
441 common epoll_pwait2 sys_epoll_pwait2 compat_sys_epoll_pwait2
442442
442 common mount_setattr sys_mount_setattr
443-
443 common quotactl_path sys_quotactl_path
443+
# 443 reserved for quotactl_path
444444
444 common landlock_create_ruleset sys_landlock_create_ruleset
445445
445 common landlock_add_rule sys_landlock_add_rule
446446
446 common landlock_restrict_self sys_landlock_restrict_self

‎arch/powerpc/kernel/syscalls/syscall.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@
522522
440 common process_madvise sys_process_madvise
523523
441 common epoll_pwait2 sys_epoll_pwait2 compat_sys_epoll_pwait2
524524
442 common mount_setattr sys_mount_setattr
525-
443 common quotactl_path sys_quotactl_path
525+
# 443 reserved for quotactl_path
526526
444 common landlock_create_ruleset sys_landlock_create_ruleset
527527
445 common landlock_add_rule sys_landlock_add_rule
528528
446 common landlock_restrict_self sys_landlock_restrict_self

‎arch/s390/kernel/syscalls/syscall.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@
445445
440 common process_madvise sys_process_madvise sys_process_madvise
446446
441 common epoll_pwait2 sys_epoll_pwait2 compat_sys_epoll_pwait2
447447
442 common mount_setattr sys_mount_setattr sys_mount_setattr
448-
443 common quotactl_path sys_quotactl_path sys_quotactl_path
448+
# 443 reserved for quotactl_path
449449
444 common landlock_create_ruleset sys_landlock_create_ruleset sys_landlock_create_ruleset
450450
445 common landlock_add_rule sys_landlock_add_rule sys_landlock_add_rule
451451
446 common landlock_restrict_self sys_landlock_restrict_self sys_landlock_restrict_self

‎arch/sh/kernel/syscalls/syscall.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@
445445
440 common process_madvise sys_process_madvise
446446
441 common epoll_pwait2 sys_epoll_pwait2
447447
442 common mount_setattr sys_mount_setattr
448-
443 common quotactl_path sys_quotactl_path
448+
# 443 reserved for quotactl_path
449449
444 common landlock_create_ruleset sys_landlock_create_ruleset
450450
445 common landlock_add_rule sys_landlock_add_rule
451451
446 common landlock_restrict_self sys_landlock_restrict_self

‎arch/sparc/kernel/syscalls/syscall.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@
488488
440 common process_madvise sys_process_madvise
489489
441 common epoll_pwait2 sys_epoll_pwait2 compat_sys_epoll_pwait2
490490
442 common mount_setattr sys_mount_setattr
491-
443 common quotactl_path sys_quotactl_path
491+
# 443 reserved for quotactl_path
492492
444 common landlock_create_ruleset sys_landlock_create_ruleset
493493
445 common landlock_add_rule sys_landlock_add_rule
494494
446 common landlock_restrict_self sys_landlock_restrict_self

‎arch/x86/entry/syscalls/syscall_32.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,7 @@
447447
440 i386 process_madvise sys_process_madvise
448448
441 i386 epoll_pwait2 sys_epoll_pwait2 compat_sys_epoll_pwait2
449449
442 i386 mount_setattr sys_mount_setattr
450-
443 i386 quotactl_path sys_quotactl_path
450+
# 443 reserved for quotactl_path
451451
444 i386 landlock_create_ruleset sys_landlock_create_ruleset
452452
445 i386 landlock_add_rule sys_landlock_add_rule
453453
446 i386 landlock_restrict_self sys_landlock_restrict_self

‎arch/x86/entry/syscalls/syscall_64.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@
364364
440 common process_madvise sys_process_madvise
365365
441 common epoll_pwait2 sys_epoll_pwait2
366366
442 common mount_setattr sys_mount_setattr
367-
443 common quotactl_path sys_quotactl_path
367+
# 443 reserved for quotactl_path
368368
444 common landlock_create_ruleset sys_landlock_create_ruleset
369369
445 common landlock_add_rule sys_landlock_add_rule
370370
446 common landlock_restrict_self sys_landlock_restrict_self

‎arch/xtensa/kernel/syscalls/syscall.tbl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@
413413
440 common process_madvise sys_process_madvise
414414
441 common epoll_pwait2 sys_epoll_pwait2
415415
442 common mount_setattr sys_mount_setattr
416-
443 common quotactl_path sys_quotactl_path
416+
# 443 reserved for quotactl_path
417417
444 common landlock_create_ruleset sys_landlock_create_ruleset
418418
445 common landlock_add_rule sys_landlock_add_rule
419419
446 common landlock_restrict_self sys_landlock_restrict_self

0 commit comments

Comments
 (0)