Skip to content

Commit ee858d8

Browse files
committed
sparc/crc: drop "glue" from filenames
The use of the term "glue" in filenames is a Crypto API-ism that rarely shows up elsewhere in lib/ or arch/*/lib/. I think adopting it there was a mistake. The library just uses standard functions, so the amount of code that could be considered "glue" is quite small. And while often the C functions just wrap the assembly functions, there are also cases like crc32c_arch() in arch/x86/lib/crc32-glue.c that blur the line by in-lining the actual implementation into the C function. That's not "glue code", but rather the actual code. Therefore, let's drop "glue" from the filenames and instead use e.g. crc32.c instead of crc32-glue.c. Reviewed-by: "Martin K. Petersen" <martin.petersen@oracle.com> Acked-by: Ard Biesheuvel <ardb@kernel.org> Link: https://lore.kernel.org/r/20250424002038.179114-7-ebiggers@kernel.org Signed-off-by: Eric Biggers <ebiggers@google.com>
1 parent fa7ed85 commit ee858d8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

arch/sparc/lib/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,4 +54,4 @@ obj-$(CONFIG_SPARC64) += iomap.o
5454
obj-$(CONFIG_SPARC32) += atomic32.o
5555
obj-$(CONFIG_SPARC64) += PeeCeeI.o
5656
obj-$(CONFIG_CRC32_ARCH) += crc32-sparc.o
57-
crc32-sparc-y := crc32_glue.o crc32c_asm.o
57+
crc32-sparc-y := crc32.o crc32c_asm.o

arch/sparc/lib/crc32_glue.c renamed to arch/sparc/lib/crc32.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// SPDX-License-Identifier: GPL-2.0-only
2-
/* Glue code for CRC32C optimized for sparc64 crypto opcodes.
2+
/* CRC32c (Castagnoli), sparc64 crc32c opcode accelerated
33
*
44
* This is based largely upon arch/x86/crypto/crc32c-intel.c
55
*

0 commit comments

Comments
 (0)